yuqi1129 commented on code in PR #12582:
URL: https://github.com/apache/gravitino/pull/12582#discussion_r3891415610
##########
core/src/main/java/org/apache/gravitino/hook/FilesetHookDispatcher.java:
##########
@@ -127,8 +127,10 @@ public boolean dropFileset(NameIdentifier ident) {
List<String> locations =
AuthorizationUtils.getMetadataObjectLocation(ident,
Entity.EntityType.FILESET);
boolean dropped = dispatcher.dropFileset(ident);
- AuthorizationUtils.authorizationPluginRemovePrivileges(
- ident, Entity.EntityType.FILESET, locations);
+ if (dropped) {
Review Comment:
Can you check the definition again for `dropFileset`? I believe we need to
confirm what `true` or `false` really means. Moreover, you may need to change
other entity types like `Table`, `Schema`, `Topic`, `Function`,`View` and so
on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
