jerryshao commented on PR #12715: URL: https://github.com/apache/gravitino/pull/12715#issuecomment-5490563034
Thanks for the thorough review! Addressed #1 and #2: 1. `JobInfo.fromJobEntity` (`toRuntimeJobTemplate`) now catches and logs instead of throwing, so a malformed/forward-incompatible stored template no longer turns an already-successful `getJob`/`runJob`/`cancelJob` into a 500. Added `TestJobInfo.testFromJobEntityWithMalformedRuntimeJobTemplateDoesNotThrow`. 2. Moved the guard into `JobOperations.toDTO()` itself (wrapping only the runtime-template deserialization step), so it now covers `get`/`run`/`cancel`/`list` uniformly instead of just `listJobs`. Added `TestJobOperations.testCancelJobWithMalformedRuntimeJobTemplateDoesNotFail`. On #3 (resolved `jobConf` values, including any secrets a caller substituted via placeholders, now being persisted/returned) - agreed this is real, but it's a design question (redaction? explicit opt-in? docs warning?) rather than a bug fix, so I'd like to handle it separately rather than block this PR on it. Will follow up in a dedicated issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
