yuqi1129 commented on code in PR #12781:
URL: https://github.com/apache/gravitino/pull/12781#discussion_r3904184810
##########
core/src/main/java/org/apache/gravitino/storage/relational/service/TagMetaService.java:
##########
@@ -143,7 +161,7 @@ public <E extends Entity & HasIdentifier> TagEntity
updateTag(
POConverters.updateTagPOWithVersion(tagPO,
updatedTagEntity), tagPO));
if (result == null || result == 0) {
- throw new IOException("Failed to update the entity: " + identifier);
+ throw tagWriteFailure(identifier, tagPO);
Review Comment:
Good catch on the observability gap. `TagManager.alterTag` and `deleteTag`
now catch `OptimisticLockException`, log a WARN naming the tag and the
metalake, and rethrow, so the operator-facing record survives the change of
exception type. The `catch (IOException ioe)` blocks stay: they are still
reachable for store failures that are not conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
