LiJie20190102 commented on code in PR #12792:
URL: https://github.com/apache/gravitino/pull/12792#discussion_r3905036393
##########
core/src/main/java/org/apache/gravitino/storage/relational/mapper/provider/base/JobTemplateMetaBaseSQLProvider.java:
##########
@@ -98,8 +99,9 @@ public String softDeleteJobTemplateMetaByMetalakeAndName(
@Param("jobTemplateName") String jobTemplateName) {
return "UPDATE "
+ JobTemplateMetaMapper.TABLE_NAME
- + " SET deleted_at = (UNIX_TIMESTAMP() * 1000.0)"
- + " + EXTRACT(MICROSECOND FROM CURRENT_TIMESTAMP(3)) / 1000.0"
+ + " SET deleted_at = "
+ + DatabaseTimeSQL.MYSQL
+ + ".0"
Review Comment:
Good catch. The original SQL used / 1000.0 (with the .0 suffix), and
DatabaseTimeSQL.MYSQL uses / 1000. My mechanical replacement left the .0 as a
dangling string fragment. Fixed in the latest push — removed the 6 residual +
".0" lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
