yuqi1129 commented on code in PR #12823:
URL: https://github.com/apache/gravitino/pull/12823#discussion_r3914879570
##########
core/src/main/java/org/apache/gravitino/storage/relational/mapper/provider/base/FunctionMetaBaseSQLProvider.java:
##########
@@ -228,11 +250,12 @@ public String selectFunctionMetaBySchemaIdAndName(
+ " vi.audit_info as version_audit_info, vi.deleted_at as
version_deleted_at"
+ " FROM "
+ TABLE_NAME
- + " fm INNER JOIN "
+ + " fm LEFT JOIN "
Review Comment:
Fixed. The standard natural-key read is back to an INNER JOIN in both the
base and PostgreSQL providers. Overwrite now uses a dedicated root-only SELECT
... FOR UPDATE, so it can lock and advance the persisted root before inserting
the next version without weakening normal reads. I also added provider
assertions and a service regression that soft-deletes the current version row
and verifies the normal read returns NoSuchEntityException instead of building
a partial FunctionPO/NPE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
