jiangxt2 commented on PR #12105: URL: https://github.com/apache/gravitino/pull/12105#issuecomment-5519238310
After reconsidering the design, I agree that applying an `ExternalType -> StringType` fallback in the shared `SparkTypeConverter` is too broad. The fallback should be handled in each engine-specific Spark Connector path, where the engine's physical schema and read semantics are available. For example, Doris-specific external types should be handled by the Doris-specific connector path rather than by a global conversion rule. Since this PR implements the global fallback, it no longer matches the intended design. I will close this PR for now and revisit the required handling as part of the corresponding engine-specific connector implementations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
