Copilot commented on code in PR #12631:
URL: https://github.com/apache/gravitino/pull/12631#discussion_r3922728814
##########
docs/trino-connector/requirements.md:
##########
@@ -9,7 +9,7 @@ license: "This software is licensed under the Apache License
version 2."
To install and deploy the Apache Gravitino Trino connector, the following
environmental setup is necessary:
-- Trino server version should be between Trino-server-440 and Trino-server-478.
+- Trino server version should be between Trino-server-440 and Trino-server-483.
The examples in this document use Trino `469` by default.
Review Comment:
The PR description states the supported Trino range is "435–479" and that it
adds only the 479 module, but the code/docs changes in this PR add
version-segment modules through 482–483 and document support starting at 440.
Please update the PR description (or the docs) so they consistently reflect the
actual supported range and the new packages added.
##########
trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/util/json/TypeSignatureDeserializer.java:
##########
@@ -47,10 +51,9 @@ public TypeSignatureDeserializer(ClassLoader classLoader) {
}
@Override
- protected TypeSignature _deserialize(String value, DeserializationContext
context) {
+ protected Object _deserialize(String value, DeserializationContext context) {
try {
- return (TypeSignature)
- parseTypeSignatureMethod.invoke(null, "varchar(255)",
ImmutableSet.of());
+ return parseTypeSignatureMethod.invoke(null, "varchar(255)",
ImmutableSet.of());
} catch (Exception e) {
throw new RuntimeException(e);
}
Review Comment:
TypeSignatureDeserializer currently ignores the input string (`value`) and
always parses the hardcoded signature "varchar(255)", which will silently
deserialize every TypeSignature to the wrong value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
