jerryshao commented on code in PR #12922:
URL: https://github.com/apache/gravitino/pull/12922#discussion_r3934552596
##########
server/src/test/java/org/apache/gravitino/server/TestGravitinoServer.java:
##########
@@ -57,6 +68,36 @@
@TestInstance(Lifecycle.PER_CLASS)
public class TestGravitinoServer {
+ // Static-asset and forwarding paths shared by both exemption sets below,
each for the same
+ // reason in both: WebUIFilter's static assets and HealthAliasServlet's
forwarded probes need
+ // no direct filter binding of their own on this path. See GH-12760.
+ private static final Set<String> STATIC_AND_FORWARDING_PATHS =
+ ImmutableSet.of(
+ "/", // DefaultServlet / WebUIFilter: serves static UI assets, no
server-side logic.
+ "/ui/*", // WebUIFilter: serves static UI assets, no server-side
logic.
+ "/health/*", // HealthAliasServlet forwards into /api/health*,
already covered via the
+ "/health.html" // FORWARD dispatcher type; binding again here would
double-log probes.
+ );
Review Comment:
Fixed — merged the /health/* and /health.html entries under one comment that
explains both together, instead of a sentence trailing off across two array
entries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
