IcebreakerSA opened a new pull request, #12933:
URL: https://github.com/apache/gravitino/pull/12933

   ### What changes were proposed in this pull request?
   
   Disable global error messages for the optional Web V2 GitHub repository 
statistics request. Failed requests still reject so the existing UI fallback 
can hide the statistics. Other requests retain their error messages.
   
   ### Why are the changes needed?
   
   GitHub rate limits currently trigger a global error toast when opening Web 
V2. Network failures for the same request can also incorrectly report that 
Gravitino is unavailable.
   
   Fix: #12239
   
   ### Does this PR introduce _any_ user-facing change?
   
   Unavailable GitHub statistics no longer produce a global error toast. No API 
or configuration changes.
   
   ### How was this patch tested?
   
   From `web-v2/web`:
   
   - `node node_modules/vitest/vitest.mjs run src/lib/api/github/index.test.js 
--maxWorkers=1 --no-file-parallelism`: all 4 tests pass. Rate-limit and 
network-failure tests fail before the fix. Tests exercise the real HTTP 
interceptors with a mocked Axios adapter.
   - Prettier and ESLint pass for both changed files.
   - Full Web V2 unit suite: 57 tests pass across 5 files; 
`src/lib/store/auth/index.test.js` fails to load because of JSX parsing in 
`src/lib/provider/session.js`. The same failure was reproduced with the 
unmodified upstream GitHub request implementation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to