yuqi1129 commented on code in PR #12824:
URL: https://github.com/apache/gravitino/pull/12824#discussion_r3947839758
##########
core/src/main/java/org/apache/gravitino/storage/relational/service/TagMetaService.java:
##########
@@ -759,25 +759,18 @@ private void insertNewTagWithoutCommit(TagPO tagPO) {
}
private TagPO findAndLockTagForOverwrite(TagPO initializedTagPO) {
Review Comment:
Fixed in 41a68b6c55. Tag now translates a concurrent first-time overwrite
unique-key conflict into OptimisticLockException, matching View. Ordinary
creates still report EntityAlreadyExistsException, and an explicit deleted-ID
check keeps permanently reserved IDs from being misclassified as retryable
conflicts.
Added database regressions for the missing-row overwrite race, successful
retry with the winning stable ID, and deleted-ID rejection followed by
replacement using a new ID. All 15 selected Tag test invocations passed across
H2, MySQL, and PostgreSQL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
