yuqi1129 commented on code in PR #12960:
URL: https://github.com/apache/gravitino/pull/12960#discussion_r3948382593
##########
docs/gravitino-mcp-server.md:
##########
@@ -225,6 +225,14 @@ For exposed or multi-caller HTTP deployments, set
`--no-service-identity-fallbac
Authorization itself is always enforced by Gravitino: the MCP server forwards
the identity but does not make access-control decisions of its own.
+### Per-request metalake (HTTP)
+
+When the server runs with HTTP transport, a request may name the metalake to
operate on with the `X-Gravitino-Metalake` header, taking priority over the
`--metalake` default configured at startup. This lets one server instance serve
more than one metalake: each request independently resolves its own metalake
from its own header, so the server holds no per-connection or per-session
metalake state and stays correct regardless of how many replicas it runs as.
+
+Falls back to `--metalake` when the header is absent. If neither is set, the
call fails with an error naming the missing argument. Authorization is
unchanged — the caller's identity (see above) determines what it may see in the
requested metalake exactly as it would through the REST API.
Review Comment:
So does `--metalake` is required or optional after this PR?
##########
docs/gravitino-mcp-server.md:
##########
@@ -144,7 +144,7 @@ You could config Gravitino MCP server by arguments, `uv run
mcp_server -h` shows
| Argument | Description
| Default value | Required |
|----------------------------------|---------------------------------------------------------------------------------------------------------------------------------|-----------------------------|----------|
-| `--metalake` | The Gravitino metalake name.
| none | Yes |
+| `--metalake` | Default Gravitino metalake, used when a
request names none. See Per-request metalake below.
| none | stdio only |
Review Comment:
Format the table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
