roryqi commented on code in PR #12976:
URL: https://github.com/apache/gravitino/pull/12976#discussion_r3956546375
##########
core/src/main/java/org/apache/gravitino/utils/PrincipalUtils.java:
##########
@@ -55,9 +55,9 @@ public static <T> T doAs(Principal principal,
PrivilegedExceptionAction<T> actio
Throwable cause = pae.getCause();
Throwables.propagateIfPossible(cause, Exception.class);
throw new RuntimeException("doAs method encountered an unexpected
exception", pae);
- } catch (Error t) {
- LOG.warn("doAs method encountered an unexpected error", t);
- throw new RuntimeException("doAs method encountered an unexpected
exception", t);
+ } catch (Error error) {
+ LOG.warn("doAs method encountered an unexpected error", error);
+ throw error;
Review Comment:
The current behavior is the server will crash.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
