lasdf1234 commented on code in PR #13204:
URL: https://github.com/apache/gravitino/pull/13204#discussion_r4025474229
##########
core/src/main/java/org/apache/gravitino/cloud/storage/COSPropertiesMetadata.java:
##########
@@ -48,6 +48,22 @@ public class COSPropertiesMetadata {
false /* immutable */,
null /* defaultValue */,
true /* hidden */))
+ .put(
+ COSProperties.GRAVITINO_COS_REGION,
+ stringOptionalPropertyEntry(
+ COSProperties.GRAVITINO_COS_REGION,
+ "Tencent Cloud COS region",
+ false /* immutable */,
+ null /* defaultValue */,
+ false /* hidden */))
+ .put(
+ COSProperties.GRAVITINO_COS_ENDPOINT,
+ stringOptionalPropertyEntry(
+ COSProperties.GRAVITINO_COS_ENDPOINT,
+ "Tencent Cloud COS endpoint",
+ false /* immutable */,
+ null /* defaultValue */,
+ false /* hidden */))
Review Comment:
Fixed in `3481e38f7`.
Added non-hidden entries in `COSPropertiesMetadata` for:
- `cos-role-arn`
- `cos-external-id`
- `cos-app-id`
Also registered `cos-token-expire-in-secs` in
`CredentialConfig.CREDENTIAL_PROPERTY_ENTRIES` (same pattern as S3/OSS/ADLS
token-expire keys).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
