LuciferYang opened a new pull request, #13241:
URL: https://github.com/apache/gravitino/pull/13241

   ### What changes were proposed in this pull request?
   
   `HourPartitioningDTO`, `MonthPartitioningDTO`, and `YearPartitioningDTO` now 
carry `@EqualsAndHashCode(callSuper = true)`, aligning them with the Day and 
Identity partitioning DTOs.
   
   ### Why are the changes needed?
   
   Without it, the three DTOs inherited `SingleFieldPartitioning`'s Lombok 
`equals`, so different strategies over the same field compared equal 
(`hour(ts).equals(month(ts))` was `true`) and Set-based dedup silently merged 
distinct strategies.
   
   Fix: #13240
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes. This changes DTO `equals`/`hashCode` semantics: Hour/Month/Year 
partitioning DTOs of different strategies over the same field are no longer 
equal. It fixes silent `Set` deduplication of distinct partitioning strategies.
   
   ### How was this patch tested?
   
   Added `TestPartitioningDTOEquality`, which pins that Hour/Month/Year 
partitioning DTOs of different strategies over the same field are not equal and 
are not collapsed by a `Set`; it fails on the pre-fix tree and passes after the 
fix.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to