LuciferYang opened a new pull request, #13247:
URL: https://github.com/apache/gravitino/pull/13247

   ### What changes were proposed in this pull request?
   
   This adds the six missing static credential keys (`azure-client-secret`, 
`aws-access-key-id`/`aws-secret-access-key`, and 
`dlf-access-key-id`/`dlf-access-key-secret`/`dlf-security-token`) to the set 
`omitStaticCredentialProperties` strips before merging REST metadata into GVFS 
client configuration.
   
   ### Why are the changes needed?
   
   The key set omitted six static credentials defined in the same module, so 
they passed straight through the filter into client configuration, violating 
the class's documented contract.
   
   Fix: #13246
   
   ### Does this PR introduce _any_ user-facing change?
   
   No. No property keys are added or removed. Six additional static credential 
keys are now stripped from REST metadata before it is merged into GVFS client 
configuration; GVFS never consumes them (they are server-side metadata used to 
mint vended credentials), so no working auth path is affected.
   
   ### How was this patch tested?
   
   Added `TestCloudStorageCredentialPropertyKeys`, which pins that the six keys 
are stripped by `omitStaticCredentialProperties`; it fails on the pre-fix tree 
(the keys passed through) and passes after the fix.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to