LuciferYang commented on PR #13227:
URL: https://github.com/apache/gravitino/pull/13227#issuecomment-5699942780
Follow-up 8eeadca32 fixes the one `build (17)` failure this PR surfaced.
`TestExpressionUtil.testPartitionFiledToExpression` asserted
`Transforms.day("f4")` for the input `hour(f4)`, a stale copy-paste expectation
that only passed because the old `instanceof`-based
`SingleFieldTransform.equals` treated an `HourTransform` and a `DayTransform`
over the same field as equal. The type-strict `equals` in this PR correctly
makes them unequal and exposed the wrong expectation; I corrected it to
`Transforms.hour("f4")`. The production `ExpressionUtil` conversion was already
correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
