LuciferYang opened a new pull request, #13229:
URL: https://github.com/apache/gravitino/pull/13229

   ### What changes were proposed in this pull request?
   
   `LiteralImpl` now compares `byte[]` values with `Arrays.equals` and 
`Object[]` values with `Arrays.deepEquals`, and uses matching structural 
`hashCode`s. Non-array semantics are unchanged.
   
   ### Why are the changes needed?
   
   `equals` fell back to `value.toString()` and `Objects.equals`, so binary 
literals with equal content were never equal and binary identity-partition 
dedup never matched.
   
   Fix: #13228
   
   ### Does this PR introduce _any_ user-facing change?
   
   No API change. Binary (`byte[]`) literals with equal content are now equal 
and hash consistently, so binary identity-partition deduplication works. 
Non-array literal semantics are unchanged.
   
   ### How was this patch tested?
   
   Added `TestLiteral.testBinaryLiteralsWithEqualContentAreEqual`, which pins 
that two binary literals with equal content are equal and hash consistently; it 
fails on the pre-fix tree and passes after the fix.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to