geyanggang commented on PR #13266: URL: https://github.com/apache/gravitino/pull/13266#issuecomment-5711993532
@danhuawang Thanks for the thorough review! Addressed all points: Must fix IMAGE_VERSION: no longer hard-coded. build-docker.sh reads version from gradle.properties and passes it as --build-arg IMAGE_VERSION; the Dockerfile default is kept in sync as a fallback. The version LABEL now resolves to 2.0.0-SNAPSHOT on main. Wired into the build path: added trino-connectors / flink-connectors / spark-connectors --type entries to build-docker.sh, plus a short Build section in each README. LICENSE/NOTICE: dropped the three committed source-tree copies. The dependency scripts now copy the repo-root LICENSE/NOTICE at build time (single source, no drift), and each image ships a THIRD_PARTY_LICENSES.txt describing the bundled third-party components. Removed the "Apache-2.0 only" wording. Suggestions copy-connector.sh: added LIST_VERSIONS=true for inspection; the install path now exits 1 when /target is not mounted. Trino resolve_version_range now returns empty with status 0 (safe under set -e). Dependency scripts keep stderr (removed 2>/dev/null); Trino copies only the bands built in this run. Spark defaults SCALA_VERSION to 2.13 for Spark 4.x, 2.12 otherwise. UBI nits: chgrp/chmod g=u now also cover /licenses; added a passwd entry for UID 1000; dropped .gitignore from the image; reworded "Certified" to "UBI 10-based, certification-oriented". Verified end-to-end: the Flink image builds via build-docker.sh, /licenses contains LICENSE + NOTICE + THIRD_PARTY_LICENSES.txt, labels/passwd are correct, and the entrypoint fails fast without /target. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
