lasdf1234 commented on PR #13153: URL: https://github.com/apache/gravitino/pull/13153#issuecomment-5714691075
@laserninja This PR need https://github.com/apache/gravitino/pull/13134 and https://github.com/apache/gravitino/pull/13138 has be merged. Those special cases don't need to be considered, so you don't need to modify the JobManager module for this PR. Additionally, for this PR, there is no need to modify any other built-in components. All that needs to be done is to focus on cleaning orphan files. The following two points do not need to be implemented. If there is a need for these two points in the future, I will restructure the code uniformly. 1. Template environments — please add .withEnvironments(GravitinoAuthSettings.jobTemplateEnvironments()) so GRAVITINO_AUTH_* placeholders are available when server auth is enabled. 2. REST catalog auth — in main(), call IcebergJobUtils.applyIcebergRestAuth(sparkBuilder, catalogName, null) before creating the Spark session (same as expire/rewrite jobs). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
