lasdf1234 commented on PR #13322:
URL: https://github.com/apache/gravitino/pull/13322#issuecomment-5729061653
> Thanks for the review, @lasdf1234. All three notes are addressed:
>
> 1. The description now separates the two rules. One is the store column
width (128), which applies to tag, policy, role, user, group and job template
names and model version aliases. The other is the name specification
(`^\w[\w/=-]{0,63}$`), which model rename now follows.
> 2. `EntityFieldLimits.checkMaxLength` now checks only the code-point count
([ffe2917](https://github.com/apache/gravitino/commit/ffe2917ff364c551d625d6b1a516a33bd4b0f9e5)).
> 3. The description now says that policy and job template comments are
`TEXT`/`CLOB` columns and stay unlimited.
>
> The same code change is also on the branch-1.3 backport, #13324.
I have reviewed the latest commit. All minor issues have been fixed. I will
approve this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
