lasdf1234 commented on code in PR #13354:
URL: https://github.com/apache/gravitino/pull/13354#discussion_r4058725326
##########
core/src/main/java/org/apache/gravitino/connector/BasePropertiesMetadata.java:
##########
@@ -88,18 +90,36 @@ protected final Map<String, PropertyEntry<?>>
buildBasePropertyEntries() {
builder.put(name, entry);
});
- // Credential vending keys (e.g. credential-providers) are valid on schema
/ fileset / table as
- // well as catalog. Register once so official non-hidden keys are not
fuzzy-masked.
- CredentialConfig.CREDENTIAL_PROPERTY_ENTRIES.forEach(
- (name, entry) -> {
- Preconditions.checkArgument(
- !properties.containsKey(name), "Property metadata already
exists: " + name);
- builder.put(name, entry);
- });
-
Review Comment:
At that time, using Base was for desensitization. Now, desensitization is
achieved through registry. When using the credentials,
CredentialConfig/ConfigEntry still performs verification. This is because there
is one less "error raised at creation time", not because desensitization has
missed something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
