mchades commented on PR #12602: URL: https://github.com/apache/gravitino/pull/12602#issuecomment-5772304718
> A lost overwrite here throws `IllegalStateException`, which no caller can classify. Fixed. The zero-row overwrite path now uses `OccWriteSupport.writeFailure`, which re-reads the persisted identity and reports `NoSuchEntityException` or `OptimisticLockException` consistently with the View and Function OCC paths. > This upsert is now unreachable, and it is the same SQL flagged last round as a version-bump trap. Fixed. `SemanticModelPOStorageOps` now rejects overwrite requests and only performs strict inserts, matching the View and Function paths. The unused identity and version-snapshot upsert mapper/provider methods have been removed. `selectSemanticModelMetaByIdForUpdate` is retained and is now used to classify overwrite failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
