FANNG1 commented on code in PR #13390:
URL: https://github.com/apache/gravitino/pull/13390#discussion_r4080789113
##########
lance/lance-common/src/main/java/org/apache/gravitino/lance/common/ops/gravitino/LanceDataTypeConverter.java:
##########
@@ -203,6 +203,10 @@ public ArrowType fromGravitino(Type type) {
@Override
public Type toGravitino(Field arrowField) {
+ if (arrowField.getMetadata() != null &&
!arrowField.getMetadata().isEmpty()) {
+ return toExternalType(arrowField);
+ }
Review Comment:
Update: the approach changed. Only Lance blob metadata is recognized now,
and containers stay native: a blob nested in a list/map/union becomes e.g.
`list<external(lance.blob.v2)>`, and only a non-canonical blob child falls back
to Arrow JSON (keeping its metadata). JSON external types now take the name
from the caller, so rebuilt child names such as `item` -> `element` no longer
fail the name check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
