lasdf1234 commented on issue #13372:
URL: https://github.com/apache/gravitino/issues/13372#issuecomment-5790284048
### Follow-up from review of #13425
Nit / edge case on the legacy staging-dir lookup in
`findLegacyJobStagingDirs`: it only looks one level under each metalake
directory (`<metalake>/<child>/job-<id>`).
The pre-upgrade layout used the raw template name in the path
(`String.format(..., metalake, jobTemplateName, jobId)`). If a template name
ever contains `/` (e.g. `team/etl`), the directory would be nested deeper
(`<metalake>/team/etl/job-<id>`), and this lookup would miss it — so those
legacy staging dirs could still leak on cleanup / template delete.
There is currently no validation that forbids `/` in job template names
(only non-blank + no `builtin-` prefix). In practice this is unlikely via the
REST path `.../templates/{name}`, but worth either:
1. walking deeper (still skipping symlinks / hidden entries), or
2. documenting / enforcing that template names must not contain `/`.
Not blocking for the common case in #13425.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
