nevzheng commented on PR #13331:
URL: https://github.com/apache/gravitino/pull/13331#issuecomment-5800451851
Closing this as unneeded.
On further design work we concluded that Gravitino should not own catalog
properties for the Iceberg
table format version at all. Iceberg already has
`table-default.format-version` and
`table-override.format-version`, with well-defined precedence, and adding
`table-format-version.default` / `table-format-version.max` alongside them
creates a second source of
truth that has to be kept consistent with the first.
The approach we settled on instead needs no new property:
- **Resolve** the effective format version using Iceberg's own precedence —
`table-override.format-version`, else the version the request names, else
`table-default.format-version`, else Iceberg's default of 2.
- **Refuse** the operation when encryption applies and the effective version
is below 3, before any
KMS call and before anything is published, naming the property an operator
would set.
- Never raise a version the user did not ask for, and never write a format
version of Gravitino's
own.
That keeps Iceberg's semantics authoritative, removes the normalisation of
encrypted creates that
this change depended on, and avoids a catalog-level gate that would have
made existing catalogs
unalterable until an operator edited them.
Apologies for the churn, and thanks to everyone who looked at these. Nothing
here is lost: the
branch keeps the commits if any of it is wanted later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
