mchades commented on code in PR #13571:
URL: https://github.com/apache/gravitino/pull/13571#discussion_r4216198733
##########
api/src/main/java/org/apache/gravitino/semantic/AIContextObject.java:
##########
@@ -370,12 +359,7 @@ private static Number canonicalizeJsonNumber(Number value,
String path) {
}
private static void enterContainer(
- Object value, String path, IdentityHashMap<Object, Boolean> visiting,
int containerDepth) {
- Preconditions.checkArgument(
- containerDepth <= MAX_ADDITIONAL_PROPERTY_NESTING_DEPTH,
- "Additional property %s exceeds maximum nesting depth of %s",
- path,
- MAX_ADDITIONAL_PROPERTY_NESTING_DEPTH);
+ Object value, String path, IdentityHashMap<Object, Boolean> visiting) {
Review Comment:
AIContext is expected to hold shallow metadata. The programmatic builder can
still overflow on sufficiently deep input, but supporting extreme nesting is
not a goal of this PR. I'd prefer to keep the current traversal and revisit it
when there is a concrete use case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
