geyanggang commented on code in PR #13769:
URL: https://github.com/apache/gravitino/pull/13769#discussion_r4246658514
##########
core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java:
##########
@@ -1826,11 +1826,12 @@ private CatalogWrapper initCatalogWrapper(
catalog.properties();
catalog.capability();
- // Eagerly initialize opted-in catalogs so a misconfiguration
fails at create rather
- // than on first use. The backend translates failures into the
caller-error vs
+ // Validate opted-in catalogs so a misconfiguration fails at
create rather than on
+ // first use. The default validation eagerly initializes ops();
JDBC overrides it to
+ // run a real backend probe. The backend translates failures into
the caller-error vs
// dependency-unavailable taxonomy; both types are forwarded by
the passthrough below.
if (propsToValidate != null && catalog.shouldValidateOnCreate()) {
- catalog.ops();
+ catalog.validateOnCreate();
Review Comment:
Fixed. CatalogManager.testConnection now builds the wrapper with null
propsToValidate, so create-time validation does not run there; only the
explicit probe executes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
