roryqi commented on code in PR #14237:
URL: https://github.com/apache/gravitino/pull/14237#discussion_r4399795739
##########
core/build.gradle.kts:
##########
@@ -22,12 +23,21 @@ plugins {
`maven-publish`
id("java")
id("idea")
+ antlr
alias(libs.plugins.jcstress)
alias(libs.plugins.jmh)
alias(libs.plugins.aspectj.post.compile.weaving)
+ alias(libs.plugins.shadow)
+}
+
+val shadedAntlr by configurations.creating {
+ isCanBeConsumed = false
}
dependencies {
+ antlr(libs.antlr.tool)
+ shadedAntlr(libs.antlr.runtime)
+ compileOnly(libs.antlr.runtime)
Review Comment:
Agreed. The unrelocated module output needs org.antlr.v4.runtime on the
launch classpath, while the packaged core JAR supplies the relocated runtime.
Added a note to CONTRIBUTING.md in b5eaee4375 explaining the IDE classpath
requirement and the packaged-server remote debugging alternative. This is based
on the dependency configuration; I have not tested an IntelliJ launch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
