dengc367 opened a new pull request, #14355:
URL: https://github.com/apache/gravitino/pull/14355

   
   ### What changes were proposed in this pull request?
   
   Bump the managed `com.aliyun.oss:aliyun-sdk-oss` version from 3.10.2 to 
3.13.0 in
   `gradle/libs.versions.toml`, with a comment recording why.
   
   That catalog entry is the only place the SDK is pinned, and it is consumed 
only by
   `:bundles:iceberg-aliyun-bundle`. 3.13.0 is the version `hadoop-project` 
3.3.6 already
   manages and the version `:bundles:aliyun-bundle` already resolves through
   `hadoop-aliyun`, so the change removes a version skew rather than adding a 
new one.
   
   ### Why are the changes needed?
   
   Fixes #`14354`
   
   Iceberg 1.11.0's `OSSFileIO` is compiled against `aliyun-sdk-oss` 3.13.0. 
Since 3.13.0,
   `OSS#deleteObject(String, String)` returns `VoidResult`; in 3.10.2 it 
returns `void`. The
   shaded Iceberg Aliyun bundle packed 3.10.2, so `OSSFileIO.deleteFile` failed 
to link and
   every delete on an OSS warehouse threw `NoSuchMethodError`.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No API change, no new or removed property keys. OSS deletes work again with 
the Iceberg
   Aliyun bundle; no other module resolves this dependency, so nothing else 
changes.
   
   ### How was this patch tested?
   
   - `./gradlew :bundles:iceberg-aliyun-bundle:dependencyInsight --dependency 
com.aliyun.oss:aliyun-sdk-oss`
     → `3.13.0` after the change (`3.10.2` before), and 
`:bundles:aliyun-bundle` already
     resolved `3.13.0` before the change.
   - `./gradlew :bundles:iceberg-aliyun-bundle:spotlessCheck 
:bundles:iceberg-aliyun-bundle:test`
     passes.
   - Inspected the built shade jar: 
`META-INF/maven/com.aliyun.oss/aliyun-sdk-oss/pom.properties`
     reports `version=3.13.0`, and `javap` on the packaged `com.aliyun.oss.OSS` 
shows
     `VoidResult deleteObject(String, String)`.
   - Cross-checked the API difference with `javap` against the 3.10.2 and 
3.13.0 jars
     (`void` vs `VoidResult`).
   - Manually: create and drop an Iceberg table on a real OSS warehouse with 
the Iceberg
     Aliyun bundle.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to