diqiu50 commented on PR #14561: URL: https://github.com/apache/gravitino/pull/14561#issuecomment-6627029389
Thanks for the reviews. Fixes are in 51d7332f9 and f6685bc5d, and the inline threads have the details. Two points from the review summary: - **Register-mode alter:** left as is here. #14565 rewrites this path: it builds the input from the full stored table and passes `versionId`. - **Partition names:** get and drop accept only the escaped form that list and add return. An unescaped `/` in a value cannot be told from a segment separator there, while add can check the name against the given values. `parsePartitionName` now documents this. Tested with the Glue unit tests, the Moto and real AWS integration tests, and the core `org.apache.gravitino.catalog` tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
