roryqi commented on code in PR #14595:
URL: https://github.com/apache/gravitino/pull/14595#discussion_r4463244972
##########
iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/ops/IcebergCatalogWrapper.java:
##########
@@ -282,6 +282,14 @@ public void dropTable(TableIdentifier tableIdentifier) {
public void purgeTable(TableIdentifier tableIdentifier) {
getMetadataCache().invalidate(tableIdentifier);
+ if (isRESTCatalog()) {
+ // A remote REST catalog owns its table files and the storage access to
them. Forward the
+ // purge so the remote deletes the files, rather than deleting them from
this server.
+ if (!getCatalog().dropTable(tableIdentifier, true)) {
Review Comment:
We shouldn't add the code. Our origin code has handled the similar cases. I
have a class `FederatedCatalogWrapper`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
