PiotrAndrzejewsky opened a new issue, #14742: URL: https://github.com/apache/gravitino/issues/14742
### What would you like to be improved? In the Java client, `Catalog` defines methods to access credential and secret operations: - `Catalog#supportsCredentials()` -> `SupportsCredentials` - `Catalog#supportsSecrets()` -> `SupportsSecrets` Furthermore, `RelationalCatalog` in Java implements both `SupportsCredentials` and `SupportsSecrets`. However, in the Python client SDK (`clients/client-python`): 1. `Catalog` (`gravitino/api/catalog.py`) does not declare `supports_credentials()` or `supports_secrets()`, unlike `supports_tags()`, `supports_policies()`, and `supports_roles()`. 2. `base_schema_catalog` instantiates `self._object_credential_operations` in `__init__`, but does not implement `supports_credentials` or expose `get_credentials()`. 3. `relational_catalog` does not implement `supports_credentials`, preventing users from retrieving vended credentials on relational catalogs. 4. `fileset_catalog` and `relational_catalog` expose `support_credentials()` / `support_secrets()` (singular form without `s`), which is inconsistent with `supports_tags`, `supports_policies`, `supports_roles`, and the Java API. ### How should we improve? 1. Add `supports_credentials()` and `supports_secrets()` to `gravitino.api.catalog.Catalog`. 2. Implement `supports_credentials` in `base_schema_catalog` using the existing `_object_credential_operations`. 3. Provide standard `supports_credentials()` and `supports_secrets()` methods while keeping `support_credentials()` and `support_secrets()` as aliases for backwards compatibility. 4. Add unit test coverage in `test_credential_api.py` and `test_relational_catalog.py`. I have already investigated the codebase and would be happy to work on this. Could you please assign this issue to me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
