PiotrAndrzejewsky commented on issue #11008: URL: https://github.com/apache/gravitino/issues/11008#issuecomment-6615620232
Hi, I would like to start contributing to this project, I see that most of the work for this issue has been done here https://github.com/apache/gravitino/issues/11947 but I see that the test coverage for this issue is a bit worse than for the equivalent issue for client-java https://github.com/apache/gravitino/issues/10987 Specifically: - alter_view variants: Currently only ViewChange.rename is tested through alter_view. Tests for set_property, remove_property, and replace_view (updating columns and query representations) are missing. - Client-side namespace validation: Tests verifying that list_views and view path formatting fail fast when an invalid namespace length is provided (e.g. Namespace.of("s1", "s2")). - Error & edge cases: create_view with 404 rejecting empty/null representations on the catalog empty results for list_views, and 500 error handling on drop_view. There are also missing integration test. In the live integration test test_relational_catalog_alter_view currently only tests properties (set_property and remove_property). I can add integration tests covering live view rename and replace_view operations against the backend catalog. And the same is true for documentation, it should also be updated. Let me know if you would like to see anything more, but I would be happy to work on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
