lasdf1234 commented on code in PR #14584:
URL: https://github.com/apache/gravitino/pull/14584#discussion_r4477359914
##########
core/src/main/java/org/apache/gravitino/catalog/SchemaNormalizeDispatcher.java:
##########
@@ -87,6 +90,7 @@ public Schema createSchema(
Map<String, SecretBinding> secretBindings,
Map<String, SecretReference> secretReferences)
throws NoSuchCatalogException, SchemaAlreadyExistsException {
+ checkCommentLength(comment);
Review Comment:
Comment length is checked on create here, but `alterSchema` does not call
`checkCommentLength` for `UpdateComment`. Issue #14578 asked to enforce the
256-char limit consistently with alter. Please either validate comment changes
in `alterSchema` (same pattern as `TopicNormalizeDispatcher`) or document why
alter is already covered elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
