lasdf1234 commented on issue #12302:
URL: https://github.com/apache/gravitino/issues/12302#issuecomment-6792252069

   ## Scope update: M5 folded into M4
   
   #12303 (M5) is closed and merged into this issue. Please treat the 
deliverable below as the current M4 scope (title/body edit needs triage write 
access — @roryqi please apply if you can).
   
   ### Proposed title
   
   `[Subtask] M4: Convenience helpers, protocol/cipher, and system-truststore 
mTLS`
   
   ### Proposed body
   
   ### Describe the subtask
   
   Combines the former M4 (ergonomics) and M5 (completeness) into one subtask.
   After M3, every journey is possible through the builder; this makes the 
common
   ones short via helpers, and closes the two helper gaps M3 left open.
   
   A user configuring the standard cases — trust an internal CA, present a 
client
   certificate, enforce TLS 1.3 / cipher suites, or present a client certificate
   while using the system truststore — should not need to hand-implement
   `TLSConfigurer` or touch `SSLContext` / `KeyStore` directly.
   
   ## Deliverable
   
   - **Common-path helpers** on the configurer factory so the typical call site
     shrinks to one line per concern (a truststore, mutual TLS) with sensible
     defaults for everything else — store type, hostname verification, context
     algorithm. Example shape (exact names in the PR):
   
     ```java
     TLSConfigurers.withTrustStore(truststore, password);
     TLSConfigurers.withMutualTls(truststore, trustPassword, keystore, 
keyPassword);
     ```
   
   - **Protocol and cipher-suite configuration through the helper**, not only 
via
     the interface — so compliance deployments can enforce TLS 1.3 (or a cipher
     list) without custom code.
   
   - **Keystore-only / system-truststore mTLS** — present a client certificate
     while relying on the platform default trust (no explicit truststore).
   
   Discipline: every helper must map to a journey named in the design doc.
   Convenience surface is still public surface — we maintain it forever — so no
   speculative methods. If a helper seems useful but has no CUJ behind it, amend
   the design doc first.
   
   ## Acceptance criteria
   
   - [ ] The private-CA and mutual-TLS journeys are expressible without touching
         `SSLContext`, `KeyStore`, or any JSSE type directly
   - [ ] Every helper corresponds to a CUJ in the design doc
   - [ ] A deployment can enforce TLS 1.3 (or a cipher list) through the helper
         alone
   - [ ] A test proves the protocol/cipher constraint binds: a handshake outside
         the permitted protocols actually fails
   - [ ] Client-cert-with-default-trust is expressible and tested against a
         trusted server certificate
   - [ ] Docs examples updated to the shortened / helper form (including the two
         completeness journeys)
   - [ ] Tests for each helper, including failure messages on bad input
   
   Depends on: M3.
   
   Note: Former standalone M5 (#12303) is folded into this issue and closed.
   
   ### Parent issue
   
   #9836


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to