anilkumgopalap commented on code in PR #14862:
URL: https://github.com/apache/gravitino/pull/14862#discussion_r4643495093


##########
catalogs/catalog-lakehouse-generic/src/main/java/org/apache/gravitino/catalog/lakehouse/generic/LocationProvider.java:
##########
@@ -68,6 +72,14 @@
  * requests. A failure on the provisioning path fails the table creation; one 
on the drop path is
  * logged at WARN and nothing else happens.
  *
+ * <p><b>Schemas.</b> Services that allocate storage usually do so 
hierarchically: a schema is
+ * registered first, with the owner and the storage domain it belongs to, and 
the paths of its
+ * tables are derived from it. A provider takes part in that by overriding 
{@link
+ * #provisionSchemaLocation(SchemaLocationContext)} and {@link
+ * #unprovisionSchemaLocation(SchemaLocationContext)}. Both default to doing 
nothing, so a provider
+ * that only places tables is not involved in schemas. They are called 
concurrently as well, and a

Review Comment:
   Reworded. It means `provisionSchemaLocation` and `unprovisionSchemaLocation` 
can be invoked concurrently by different schema requests (like the table 
callbacks), so implementations must be thread-safe.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to