(groovy) branch master updated: Tweak logging for macro

[sunlan]

This is an automated email from the ASF dual-hosted git repository.

sunlan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/groovy.git


The following commit(s) were added to refs/heads/master by this push:
     new 03fdae2a8e Tweak logging for macro
03fdae2a8e is described below

commit 03fdae2a8eed3b8350561198553ebf489e896be5
Author: Daniel Sun <sun...@apache.org>
AuthorDate: Sat Nov 18 18:54:53 2023 +0800

    Tweak logging for macro
---
 .../codehaus/groovy/macro/transform/MacroClassTransformation.java  | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git 
a/subprojects/groovy-macro/src/main/groovy/org/codehaus/groovy/macro/transform/MacroClassTransformation.java
 
b/subprojects/groovy-macro/src/main/groovy/org/codehaus/groovy/macro/transform/MacroClassTransformation.java
index 6928ab8b81..46c866e7f2 100644
--- 
a/subprojects/groovy-macro/src/main/groovy/org/codehaus/groovy/macro/transform/MacroClassTransformation.java
+++ 
b/subprojects/groovy-macro/src/main/groovy/org/codehaus/groovy/macro/transform/MacroClassTransformation.java
@@ -34,9 +34,12 @@ import org.codehaus.groovy.control.CompilePhase;
 import org.codehaus.groovy.control.SourceUnit;
 import org.codehaus.groovy.macro.methods.MacroGroovyMethods;
 import org.codehaus.groovy.macro.runtime.MacroBuilder;
+import org.codehaus.groovy.runtime.DefaultGroovyMethods;
 import org.codehaus.groovy.transform.GroovyASTTransformation;
 
 import java.util.List;
+import java.util.logging.Level;
+import java.util.logging.Logger;
 
 import static org.codehaus.groovy.ast.tools.GeneralUtils.args;
 import static org.codehaus.groovy.ast.tools.GeneralUtils.callX;
@@ -55,6 +58,7 @@ public class MacroClassTransformation extends 
MethodCallTransformation {
 
     private static final String MACRO_METHOD = "macro";
     private static final ClassNode MACROCLASS_TYPE = 
ClassHelper.make(MacroClass.class);
+    private static final Logger LOGGER = 
Logger.getLogger(MacroClassTransformation.class.getName());
 
     @Override
     protected GroovyCodeVisitor getTransformer(final ASTNode[] nodes, final 
SourceUnit sourceUnit) {
@@ -123,8 +127,7 @@ public class MacroClassTransformation extends 
MethodCallTransformation {
                         List<ClassNode> classes = 
sourceUnit.getAST().getClasses();
                         classes.removeIf(aClass -> aClass == type || type == 
aClass.getOuterClass());
                     } catch (Exception e) {
-                        // FIXME
-                        e.printStackTrace();
+                        LOGGER.log(Level.WARNING, 
DefaultGroovyMethods.asString(e));
                     }
                     return;
                 }