(groovy) branch master updated: Trivial refactoring: extract constant

[sunlan]

This is an automated email from the ASF dual-hosted git repository.

sunlan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/groovy.git


The following commit(s) were added to refs/heads/master by this push:
     new 5f23e6d319 Trivial refactoring: extract constant
5f23e6d319 is described below

commit 5f23e6d319eafa176dc70b9d3b1b84ce311ac730
Author: Daniel Sun <sun...@apache.org>
AuthorDate: Sun Jan 19 06:50:29 2025 +0900

    Trivial refactoring: extract constant
---
 src/main/java/org/apache/groovy/parser/antlr4/AstBuilder.java | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/main/java/org/apache/groovy/parser/antlr4/AstBuilder.java 
b/src/main/java/org/apache/groovy/parser/antlr4/AstBuilder.java
index 28379ce9d1..333c68745e 100644
--- a/src/main/java/org/apache/groovy/parser/antlr4/AstBuilder.java
+++ b/src/main/java/org/apache/groovy/parser/antlr4/AstBuilder.java
@@ -377,7 +377,6 @@ import static 
org.codehaus.groovy.runtime.DefaultGroovyMethods.last;
  * Builds the AST from the parse tree generated by Antlr4.
  */
 public class AstBuilder extends GroovyParserBaseVisitor<Object> {
-
     public AstBuilder(final SourceUnit sourceUnit, final boolean 
groovydocEnabled, final boolean runtimeGroovydocEnabled) {
         this.sourceUnit = sourceUnit;
         this.moduleNode = new ModuleNode(sourceUnit);
@@ -3492,7 +3491,7 @@ public class AstBuilder extends 
GroovyParserBaseVisitor<Object> {
                 }
 
                 var initializer = ctx.arrayInitializer();
-                initializer.putNodeMetaData("elementType", elementType);
+                initializer.putNodeMetaData(ELEMENT_TYPE, elementType);
                 List<Expression> initExpressions = 
this.visitArrayInitializer(initializer);
 
                 ArrayExpression arrayExpression = new 
ArrayExpression(elementType, initExpressions);
@@ -3592,7 +3591,7 @@ public class AstBuilder extends 
GroovyParserBaseVisitor<Object> {
             return Collections.emptyList();
         }
 
-        ClassNode elementType = ctx.getNodeMetaData("elementType");
+        ClassNode elementType = ctx.getNodeMetaData(ELEMENT_TYPE);
         try {
             visitingArrayInitializerCount += 1;
             var initExpressions = new ArrayList<Expression>();
@@ -3602,7 +3601,7 @@ public class AstBuilder extends 
GroovyParserBaseVisitor<Object> {
                     var arrayInitializer = (ArrayInitializerContext) c;
                     ClassNode subType = elementType.getComponentType();
                     //if (subType == null) produce closure or throw exception
-                    arrayInitializer.putNodeMetaData("elementType", subType);
+                    arrayInitializer.putNodeMetaData(ELEMENT_TYPE, subType);
                     var arrayExpression = configureAST(new 
ArrayExpression(subType,
                             this.visitArrayInitializer(arrayInitializer)), 
arrayInitializer);
                     arrayExpression.setType(elementType);
@@ -5055,5 +5054,6 @@ public class AstBuilder extends 
GroovyParserBaseVisitor<Object> {
     private static final String PARAMETER_CONTEXT = "_PARAMETER_CONTEXT";
     private static final String IS_RECORD_GENERATED = "_IS_RECORD_GENERATED";
     private static final String RECORD_HEADER = "_RECORD_HEADER";
+    private static final String ELEMENT_TYPE = "elementType";
     private static final String RECORD_TYPE_NAME = 
"groovy.transform.RecordType";
 }