This is an automated email from the ASF dual-hosted git repository.

sunlan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/groovy.git


The following commit(s) were added to refs/heads/master by this push:
     new c04e3126b0 Tweak thread name and add logging guard
c04e3126b0 is described below

commit c04e3126b052f7da22511e8080090ba9cbfa8e2b
Author: Daniel Sun <[email protected]>
AuthorDate: Sun Jan 19 15:14:46 2025 +0900

    Tweak thread name and add logging guard
---
 .../groovy/parser/antlr4/internal/atnmanager/AtnManager.java       | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git 
a/src/main/java/org/apache/groovy/parser/antlr4/internal/atnmanager/AtnManager.java
 
b/src/main/java/org/apache/groovy/parser/antlr4/internal/atnmanager/AtnManager.java
index 535413f60b..642090ca14 100644
--- 
a/src/main/java/org/apache/groovy/parser/antlr4/internal/atnmanager/AtnManager.java
+++ 
b/src/main/java/org/apache/groovy/parser/antlr4/internal/atnmanager/AtnManager.java
@@ -28,6 +28,7 @@ import java.lang.ref.ReferenceQueue;
 import java.lang.ref.SoftReference;
 import java.util.concurrent.atomic.AtomicLong;
 import java.util.concurrent.locks.ReentrantReadWriteLock;
+import java.util.logging.Level;
 import java.util.logging.Logger;
 
 /**
@@ -62,10 +63,12 @@ public abstract class AtnManager {
                     }
                 } catch (Throwable t) {
                     Logger logger = 
Logger.getLogger(MethodHandles.lookup().lookupClass().getName());
-                    logger.warning(DefaultGroovyMethods.asString(t));
+                    if (logger.isLoggable(Level.WARNING)) {
+                        logger.warning(DefaultGroovyMethods.asString(t));
+                    }
                 }
             }
-        }, "Cleanup thread for DFA cache[" + this.getClass().getSimpleName() + 
"]");
+        }, "DFA-cache-cleaner[" + this.getClass().getSimpleName() + "]");
         cleanupThread.setDaemon(true);
         cleanupThread.start();
     }

Reply via email to