[
https://issues.apache.org/jira/browse/GUACAMOLE-585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Couchman resolved GUACAMOLE-585.
-------------------------------------
Resolution: Fixed
> Dead code in JavaScript formField module
> ----------------------------------------
>
> Key: GUACAMOLE-585
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-585
> Project: Guacamole
> Issue Type: Bug
> Components: guacamole
> Affects Versions: 0.9.14
> Reporter: Nick Couchman
> Assignee: Nick Couchman
> Priority: Minor
> Fix For: 1.0.1
>
>
> Reported by Coverity:
> {quote}
> ________________________________________________________________________________________________________
> *** CID 1436956: Control flow issues (DEADCODE)
> /guacamole/src/main/webapp/app/form/directives/formField.js: 125 in
> $scope.getFieldOption()
> 119 $scope.getFieldOption = function getFieldOption(value) {
> 120
> 121 // If no field, or no value, then no corresponding
> translation string
> 122 if (!$scope.field || !$scope.field.name || !value)
> 123 return '';
> 124
> >>> CID 1436956: Control flow issues (DEADCODE)
> >>> Execution cannot reach the expression ""EMPTY"" inside this statement:
> >>> "return translationStringSer...".
> 125 return
> translationStringService.canonicalize($scope.namespace || 'MISSING_NAMESPACE')
> 126 + '.FIELD_OPTION_' +
> translationStringService.canonicalize($scope.field.name)
> 127 + '_' +
> translationStringService.canonicalize(value || 'EMPTY');
> 128
> 129 };
> 130
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)