[
https://issues.apache.org/jira/browse/GUACAMOLE-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633938#comment-16633938
]
Nick Couchman commented on GUACAMOLE-638:
-----------------------------------------
[~TonyGeeUK] Definitely appreciate the patch - we would love it if you'd be
willing to do a pull request on the code and contribute to the project!
Overall contribution guidelines are here:
http://guacamole.apache.org/open-source/
Basically you'd just need to fork the code, create a branch for the changes,
make the changes, and then create a pull request. You'll want to make sure
that the Pull Request and commits follow the contribution guidelines (they
should reference this JIRA issue), and that the code style is consistent with
the style used throughout the project.
> Compile error: 'avcodec_register_all' is deprecated
> ---------------------------------------------------
>
> Key: GUACAMOLE-638
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-638
> Project: Guacamole
> Issue Type: Bug
> Components: guacamole-server
> Affects Versions: 1.0.0
> Environment: Fedora 28
> Reporter: Tony Gale
> Priority: Major
>
> Compile error with Fedora 28:
> guacenc.c: In function 'main':
> guacenc.c:79:5: error: 'avcodec_register_all' is deprecated
> [-Werror=deprecated-declarations]
> avcodec_register_all();
> ^~~~~~~~~~~~~~~~~~~~
> In file included from guacenc.c:27:
> /usr/include/ffmpeg/libavcodec/avcodec.h:4086:6: note: declared here
> void avcodec_register_all(void);
> ^~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> Here's a patch:
> --- guacenc.c 2018-09-28 02:25:30.000000000 +0100
> +++ guacenc.c 2018-09-28 15:30:26.849265324 +0100
> @@ -76,7 +76,9 @@
> "version " VERSION);
>
> /* Prepare libavcodec */
> +#if LIBAVCODEC_VERSION_INT < AV_VERSION_INT(58, 9, 100)
> avcodec_register_all();
> +#endif
>
> /* Track number of overall failures */
> int total_files = argc - optind;
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
