[ https://issues.apache.org/jira/browse/GUACAMOLE-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15806405#comment-15806405 ]
Nick Couchman edited comment on GUACAMOLE-47 at 1/7/17 4:21 PM: ---------------------------------------------------------------- So, code should be ready for review and to try out - if people think I should submit a pull request, I will, or if you'd rather review in my git repo before that, that's fine by me. I think I messed up one of the contribution guidelines in that I committed to the master branch instead of creating a separate branch, but hopefully that's not a show-stopper. If it is, I'll redo it. Here's the repo URL: https://github.com/necouchman/incubator-guacamole-client To use it, compile and load up the guacamole code. The two new tokens are: - GUAC_REMHOST - GUAC_REMIP If you're connecting to Guacamole directly through Tomcat this should work with no additional configuration, aside from using the tokens in the connection configuration. If you're using a proxy, you'll need to do one of two things: 1) Define the X-Guacamole-Client-Hostname and/or X-Guacamole-Client-IP headers. Here's an example for Apache that uses the REMOTE_HOST and REMOTE_ADDR headers: {code} RequestHeader set X-Guacamole-Client-Hostname %{REMOTE_HOST}s RequestHeader set X-Guacamole-Client-IP %{REMOTE_ADDR}s {code} 2) Configure Tomcat to allow the X-Forwarded-For header to be passed through. This is done with the following configuration in server.xml. Remember this will only ever have the IP address - X-Forwarded-For never has the hostname. {code:xml} <Valve className="org.apache.catalina.valves.RemoteIpValve" internalProxies="127.0.0.1" remoteIpHeader="x-forwarded-for" remoteIpProxiesHeader="x-forwarded-by" protocolHeader="x-forwarded-proto" /> {code} Note that you need to set internalProxies to the list of hosts that are proxying to Guacamole. In my case I'm just doing it on the local system, so I have 127.0.0.1. was (Author: nick.couch...@yahoo.com): So, code should be ready for review and to try out - if people think I should submit a pull request, I will, or if you'd rather review in my git repo before that, that's fine by me. I think I messed up one of the contribution guidelines in that I committed to the master branch instead of creating a separate branch, but hopefully that's not a show-stopper. If it is, I'll redo it. Here's the repo URL: https://github.com/necouchman/incubator-guacamole-client To use it, compile and load up the guacamole code. The two new tokens are: - GUAC_REMHOST - GUAC_REMIP If you're connecting to Guacamole directly through Tomcat this should work with no additional configuration, aside from using the tokens in the connection configuration. If you're using a proxy, you'll need to do one of two things: 1) Define the X-Guacamole-Client-Hostname and/or X-Guacamole-Client-IP headers. Here's an example for Apache that uses the REMOTE_HOST and REMOTE_ADDR headers: RequestHeader set X-Guacamole-Client-Hostname %{REMOTE_HOST}s RequestHeader set X-Guacamole-Client-IP %{REMOTE_ADDR}s 2) Configure Tomcat to allow the X-Forwarded-For header to be passed through. This is done with the following configuration in server.xml. Remember this will only ever have the IP address - X-Forwarded-For never has the hostname. <Valve className="org.apache.catalina.valves.RemoteIpValve" internalProxies="127.0.0.1" remoteIpHeader="x-forwarded-for" remoteIpProxiesHeader="x-forwarded-by" protocolHeader="x-forwarded-proto" /> Note that you need to set internalProxies to the list of hosts that are proxying to Guacamole. In my case I'm just doing it on the local system, so I have 127.0.0.1. > Get client hostname for use in guac RDP session > ----------------------------------------------- > > Key: GUACAMOLE-47 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-47 > Project: Guacamole > Issue Type: New Feature > Components: guacamole-client > Affects Versions: 0.9.9 > Reporter: Zach Bonjour > Priority: Minor > > The "Clientname" variable should show the client name connected to the Apache > server. I am not a programmer, but if I am understanding this right, there > is a java servlet that could gather that information so it can be used in the > Guacamole session. > http://docs.oracle.com/javaee/6/api/javax/servlet/ServletRequest.html#getRemoteHost() > Is this possible? -- This message was sent by Atlassian JIRA (v6.3.4#6332)