(hbase) 02/02: HBASE-28666 Dropping unclosed WALTailingReaders leads to leaked sockets (#5994)

[zhangduo]

This is an automated email from the ASF dual-hosted git repository.

zhangduo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hbase.git

commit 60c46118e21319651c099928ab929800d0de92b4
Author: Charles Connell <cconn...@hubspot.com>
AuthorDate: Sat Jun 15 22:15:20 2024 -0400

    HBASE-28666 Dropping unclosed WALTailingReaders leads to leaked sockets 
(#5994)
    
    In WALEntryStream, always use current WALTailingReader if one exists
    
    Signed-off-by: Duo Zhang <zhang...@apache.org>
---
 .../org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java | 1 +
 1 file changed, 1 insertion(+)

diff --git 
a/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
 
b/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
index 186d5b7c4d1..8d74d0e0399 100644
--- 
a/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
+++ 
b/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
@@ -219,6 +219,7 @@ class WALEntryStream implements Closeable {
             // we will read from the beginning so we should always clear the 
compression context
             reader.resetTo(-1, true);
           }
+          return HasNext.YES;
         } catch (IOException e) {
           LOG.warn("Failed to reset reader {} to pos {}, reset 
compression={}", currentPath,
             currentPositionOfEntry, state.resetCompression(), e);