This is an automated email from the ASF dual-hosted git repository.

zhangduo pushed a commit to branch branch-3
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/branch-3 by this push:
     new 793755ef3fe HBASE-29004 Optimize unnecessary type castings in Scan and 
Get setter methods. (#6574)
793755ef3fe is described below

commit 793755ef3fecc9f6e59e31cfb4ee300bde496fe5
Author: chandrasekhar-188k 
<[email protected]>
AuthorDate: Sat Jan 18 07:55:02 2025 +0530

    HBASE-29004 Optimize unnecessary type castings in Scan and Get setter 
methods. (#6574)
    
    Signed-off-by: Duo Zhang <[email protected]>
---
 .../java/org/apache/hadoop/hbase/client/Get.java   | 33 ++++++++++++++--------
 .../java/org/apache/hadoop/hbase/client/Scan.java  | 33 ++++++++++++++--------
 2 files changed, 44 insertions(+), 22 deletions(-)

diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java 
b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java
index 6cf036d4842..e95dfd46606 100644
--- a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java
+++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java
@@ -214,7 +214,8 @@ public class Get extends Query implements Row {
 
   @Override
   public Get setColumnFamilyTimeRange(byte[] cf, long minStamp, long maxStamp) 
{
-    return (Get) super.setColumnFamilyTimeRange(cf, minStamp, maxStamp);
+    super.setColumnFamilyTimeRange(cf, minStamp, maxStamp);
+    return this;
   }
 
   /**
@@ -242,7 +243,8 @@ public class Get extends Query implements Row {
 
   @Override
   public Get setLoadColumnFamiliesOnDemand(boolean value) {
-    return (Get) super.setLoadColumnFamiliesOnDemand(value);
+    super.setLoadColumnFamiliesOnDemand(value);
+    return this;
   }
 
   /**
@@ -476,46 +478,55 @@ public class Get extends Query implements Row {
 
   @Override
   public Get setAttribute(String name, byte[] value) {
-    return (Get) super.setAttribute(name, value);
+    super.setAttribute(name, value);
+    return this;
   }
 
   @Override
   public Get setId(String id) {
-    return (Get) super.setId(id);
+    super.setId(id);
+    return this;
   }
 
   @Override
   public Get setAuthorizations(Authorizations authorizations) {
-    return (Get) super.setAuthorizations(authorizations);
+    super.setAuthorizations(authorizations);
+    return this;
   }
 
   @Override
   public Get setACL(Map<String, Permission> perms) {
-    return (Get) super.setACL(perms);
+    super.setACL(perms);
+    return this;
   }
 
   @Override
   public Get setACL(String user, Permission perms) {
-    return (Get) super.setACL(user, perms);
+    super.setACL(user, perms);
+    return this;
   }
 
   @Override
   public Get setConsistency(Consistency consistency) {
-    return (Get) super.setConsistency(consistency);
+    super.setConsistency(consistency);
+    return this;
   }
 
   @Override
   public Get setReplicaId(int Id) {
-    return (Get) super.setReplicaId(Id);
+    super.setReplicaId(Id);
+    return this;
   }
 
   @Override
   public Get setIsolationLevel(IsolationLevel level) {
-    return (Get) super.setIsolationLevel(level);
+    super.setIsolationLevel(level);
+    return this;
   }
 
   @Override
   public Get setPriority(int priority) {
-    return (Get) super.setPriority(priority);
+    super.setPriority(priority);
+    return this;
   }
 }
diff --git 
a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java 
b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java
index f132459a9c0..c2caac844a8 100644
--- a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java
+++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java
@@ -324,7 +324,8 @@ public class Scan extends Query {
 
   @Override
   public Scan setColumnFamilyTimeRange(byte[] cf, long minStamp, long 
maxStamp) {
-    return (Scan) super.setColumnFamilyTimeRange(cf, minStamp, maxStamp);
+    super.setColumnFamilyTimeRange(cf, minStamp, maxStamp);
+    return this;
   }
 
   /**
@@ -717,7 +718,8 @@ public class Scan extends Query {
 
   @Override
   public Scan setLoadColumnFamiliesOnDemand(boolean value) {
-    return (Scan) super.setLoadColumnFamiliesOnDemand(value);
+    super.setLoadColumnFamiliesOnDemand(value);
+    return this;
   }
 
   /**
@@ -847,47 +849,56 @@ public class Scan extends Query {
 
   @Override
   public Scan setAttribute(String name, byte[] value) {
-    return (Scan) super.setAttribute(name, value);
+    super.setAttribute(name, value);
+    return this;
   }
 
   @Override
   public Scan setId(String id) {
-    return (Scan) super.setId(id);
+    super.setId(id);
+    return this;
   }
 
   @Override
   public Scan setAuthorizations(Authorizations authorizations) {
-    return (Scan) super.setAuthorizations(authorizations);
+    super.setAuthorizations(authorizations);
+    return this;
   }
 
   @Override
   public Scan setACL(Map<String, Permission> perms) {
-    return (Scan) super.setACL(perms);
+    super.setACL(perms);
+    return this;
   }
 
   @Override
   public Scan setACL(String user, Permission perms) {
-    return (Scan) super.setACL(user, perms);
+    super.setACL(user, perms);
+    return this;
   }
 
   @Override
   public Scan setConsistency(Consistency consistency) {
-    return (Scan) super.setConsistency(consistency);
+    super.setConsistency(consistency);
+    return this;
   }
 
   @Override
   public Scan setReplicaId(int Id) {
-    return (Scan) super.setReplicaId(Id);
+    super.setReplicaId(Id);
+    return this;
   }
 
   @Override
   public Scan setIsolationLevel(IsolationLevel level) {
-    return (Scan) super.setIsolationLevel(level);
+    super.setIsolationLevel(level);
+    return this;
   }
 
   @Override
   public Scan setPriority(int priority) {
-    return (Scan) super.setPriority(priority);
+    super.setPriority(priority);
+    return this;
   }
 
   /**

Reply via email to