Repository: hbase Updated Branches: refs/heads/master d6b1d8cbf -> 20524080b
HBASE-12523 update checkstyle warnings to match our normal usage. Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/20524080 Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/20524080 Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/20524080 Branch: refs/heads/master Commit: 20524080b2c8f9fd3a4040ce6c536b1f019d7640 Parents: d6b1d8c Author: Sean Busbey <bus...@apache.org> Authored: Tue Nov 18 15:10:18 2014 -0600 Committer: Sean Busbey <bus...@apache.org> Committed: Wed Dec 3 12:40:09 2014 -0600 ---------------------------------------------------------------------- hbase-checkstyle/src/main/resources/hbase/checkstyle.xml | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/20524080/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml ---------------------------------------------------------------------- diff --git a/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml b/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml index 34fe5ec..bf84931 100644 --- a/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml +++ b/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml @@ -34,10 +34,12 @@ <module name="TreeWalker"> <module name="AvoidStarImport"/> <module name="RedundantImport"/> - <module name="UnusedImports"/> + <module name="UnusedImports"> + <property name="processJavadoc" value="true"/> + </module> <module name="LineLength"> <property name="max" value="100"/> - <property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/> + <property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://|org.apache.thrift.|com.google.protobuf.|hbase.protobuf.generated"/> </module> <module name="MethodLength"/> <module name="MethodParamPad"/> @@ -51,7 +53,10 @@ <module name="FinalClass"/> <module name="HideUtilityClassConstructor"/> <module name="InterfaceIsType"/> - <module name="VisibilityModifier"/> + <module name="VisibilityModifier"> + <property name="packageAllowed" value="true"/> + <property name="protectedAllowed" value="true"/> + </module> <module name="ArrayTypeStyle"/> <module name="UpperEll"/> <module name="NoFinalizer"/>