http://git-wip-us.apache.org/repos/asf/hbase-site/blob/45a663dd/devapidocs/src-html/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.html
----------------------------------------------------------------------
diff --git 
a/devapidocs/src-html/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.html
 
b/devapidocs/src-html/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.html
index 12c4ec2..03ef67d 100644
--- 
a/devapidocs/src-html/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.html
+++ 
b/devapidocs/src-html/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.html
@@ -31,314 +31,320 @@
 <span class="sourceLineNo">023</span>import java.util.List;<a 
name="line.23"></a>
 <span class="sourceLineNo">024</span>import java.util.Set;<a 
name="line.24"></a>
 <span class="sourceLineNo">025</span>import 
java.util.concurrent.CancellationException;<a name="line.25"></a>
-<span class="sourceLineNo">026</span><a name="line.26"></a>
-<span class="sourceLineNo">027</span>import org.apache.commons.logging.Log;<a 
name="line.27"></a>
-<span class="sourceLineNo">028</span>import 
org.apache.commons.logging.LogFactory;<a name="line.28"></a>
-<span class="sourceLineNo">029</span>import 
org.apache.hadoop.hbase.classification.InterfaceAudience;<a name="line.29"></a>
-<span class="sourceLineNo">030</span>import 
org.apache.hadoop.conf.Configuration;<a name="line.30"></a>
-<span class="sourceLineNo">031</span>import org.apache.hadoop.fs.FileSystem;<a 
name="line.31"></a>
-<span class="sourceLineNo">032</span>import org.apache.hadoop.fs.Path;<a 
name="line.32"></a>
-<span class="sourceLineNo">033</span>import 
org.apache.hadoop.hbase.TableName;<a name="line.33"></a>
-<span class="sourceLineNo">034</span>import 
org.apache.hadoop.hbase.HRegionInfo;<a name="line.34"></a>
-<span class="sourceLineNo">035</span>import 
org.apache.hadoop.hbase.HTableDescriptor;<a name="line.35"></a>
-<span class="sourceLineNo">036</span>import 
org.apache.hadoop.hbase.ServerName;<a name="line.36"></a>
-<span class="sourceLineNo">037</span>import 
org.apache.hadoop.hbase.MetaTableAccessor;<a name="line.37"></a>
-<span class="sourceLineNo">038</span>import 
org.apache.hadoop.hbase.errorhandling.ForeignException;<a name="line.38"></a>
-<span class="sourceLineNo">039</span>import 
org.apache.hadoop.hbase.errorhandling.ForeignExceptionDispatcher;<a 
name="line.39"></a>
-<span class="sourceLineNo">040</span>import 
org.apache.hadoop.hbase.errorhandling.ForeignExceptionSnare;<a 
name="line.40"></a>
-<span class="sourceLineNo">041</span>import 
org.apache.hadoop.hbase.executor.EventHandler;<a name="line.41"></a>
-<span class="sourceLineNo">042</span>import 
org.apache.hadoop.hbase.executor.EventType;<a name="line.42"></a>
-<span class="sourceLineNo">043</span>import 
org.apache.hadoop.hbase.master.MasterServices;<a name="line.43"></a>
-<span class="sourceLineNo">044</span>import 
org.apache.hadoop.hbase.master.MetricsSnapshot;<a name="line.44"></a>
-<span class="sourceLineNo">045</span>import 
org.apache.hadoop.hbase.master.SnapshotSentinel;<a name="line.45"></a>
-<span class="sourceLineNo">046</span>import 
org.apache.hadoop.hbase.master.TableLockManager;<a name="line.46"></a>
-<span class="sourceLineNo">047</span>import 
org.apache.hadoop.hbase.master.TableLockManager.TableLock;<a name="line.47"></a>
-<span class="sourceLineNo">048</span>import 
org.apache.hadoop.hbase.monitoring.MonitoredTask;<a name="line.48"></a>
-<span class="sourceLineNo">049</span>import 
org.apache.hadoop.hbase.monitoring.TaskMonitor;<a name="line.49"></a>
-<span class="sourceLineNo">050</span>import 
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos.SnapshotDescription;<a 
name="line.50"></a>
-<span class="sourceLineNo">051</span>import 
org.apache.hadoop.hbase.snapshot.ClientSnapshotDescriptionUtils;<a 
name="line.51"></a>
-<span class="sourceLineNo">052</span>import 
org.apache.hadoop.hbase.snapshot.SnapshotCreationException;<a 
name="line.52"></a>
-<span class="sourceLineNo">053</span>import 
org.apache.hadoop.hbase.snapshot.SnapshotDescriptionUtils;<a name="line.53"></a>
-<span class="sourceLineNo">054</span>import 
org.apache.hadoop.hbase.snapshot.SnapshotManifest;<a name="line.54"></a>
-<span class="sourceLineNo">055</span>import 
org.apache.hadoop.hbase.util.FSUtils;<a name="line.55"></a>
-<span class="sourceLineNo">056</span>import 
org.apache.hadoop.hbase.util.Pair;<a name="line.56"></a>
-<span class="sourceLineNo">057</span>import 
org.apache.hadoop.hbase.zookeeper.MetaTableLocator;<a name="line.57"></a>
-<span class="sourceLineNo">058</span>import 
org.apache.zookeeper.KeeperException;<a name="line.58"></a>
-<span class="sourceLineNo">059</span><a name="line.59"></a>
-<span class="sourceLineNo">060</span>/**<a name="line.60"></a>
-<span class="sourceLineNo">061</span> * A handler for taking snapshots from 
the master.<a name="line.61"></a>
-<span class="sourceLineNo">062</span> *<a name="line.62"></a>
-<span class="sourceLineNo">063</span> * This is not a subclass of 
TableEventHandler because using that would incur an extra hbase:meta scan.<a 
name="line.63"></a>
-<span class="sourceLineNo">064</span> *<a name="line.64"></a>
-<span class="sourceLineNo">065</span> * The {@link #snapshotRegions(List)} 
call should get implemented for each snapshot flavor.<a name="line.65"></a>
-<span class="sourceLineNo">066</span> */<a name="line.66"></a>
-<span class="sourceLineNo">067</span>@InterfaceAudience.Private<a 
name="line.67"></a>
-<span class="sourceLineNo">068</span>public abstract class TakeSnapshotHandler 
extends EventHandler implements SnapshotSentinel,<a name="line.68"></a>
-<span class="sourceLineNo">069</span>    ForeignExceptionSnare {<a 
name="line.69"></a>
-<span class="sourceLineNo">070</span>  private static final Log LOG = 
LogFactory.getLog(TakeSnapshotHandler.class);<a name="line.70"></a>
-<span class="sourceLineNo">071</span><a name="line.71"></a>
-<span class="sourceLineNo">072</span>  private volatile boolean finished;<a 
name="line.72"></a>
-<span class="sourceLineNo">073</span><a name="line.73"></a>
-<span class="sourceLineNo">074</span>  // none of these should ever be null<a 
name="line.74"></a>
-<span class="sourceLineNo">075</span>  protected final MasterServices 
master;<a name="line.75"></a>
-<span class="sourceLineNo">076</span>  protected final MetricsSnapshot 
metricsSnapshot = new MetricsSnapshot();<a name="line.76"></a>
-<span class="sourceLineNo">077</span>  protected final SnapshotDescription 
snapshot;<a name="line.77"></a>
-<span class="sourceLineNo">078</span>  protected final Configuration conf;<a 
name="line.78"></a>
-<span class="sourceLineNo">079</span>  protected final FileSystem fs;<a 
name="line.79"></a>
-<span class="sourceLineNo">080</span>  protected final Path rootDir;<a 
name="line.80"></a>
-<span class="sourceLineNo">081</span>  private final Path snapshotDir;<a 
name="line.81"></a>
-<span class="sourceLineNo">082</span>  protected final Path workingDir;<a 
name="line.82"></a>
-<span class="sourceLineNo">083</span>  private final MasterSnapshotVerifier 
verifier;<a name="line.83"></a>
-<span class="sourceLineNo">084</span>  protected final 
ForeignExceptionDispatcher monitor;<a name="line.84"></a>
-<span class="sourceLineNo">085</span>  protected final TableLockManager 
tableLockManager;<a name="line.85"></a>
-<span class="sourceLineNo">086</span>  protected final TableLock tableLock;<a 
name="line.86"></a>
-<span class="sourceLineNo">087</span>  protected final MonitoredTask status;<a 
name="line.87"></a>
-<span class="sourceLineNo">088</span>  protected final TableName 
snapshotTable;<a name="line.88"></a>
-<span class="sourceLineNo">089</span>  protected final SnapshotManifest 
snapshotManifest;<a name="line.89"></a>
-<span class="sourceLineNo">090</span><a name="line.90"></a>
-<span class="sourceLineNo">091</span>  protected HTableDescriptor htd;<a 
name="line.91"></a>
+<span class="sourceLineNo">026</span>import 
java.util.concurrent.locks.ReentrantLock;<a name="line.26"></a>
+<span class="sourceLineNo">027</span><a name="line.27"></a>
+<span class="sourceLineNo">028</span>import org.apache.commons.logging.Log;<a 
name="line.28"></a>
+<span class="sourceLineNo">029</span>import 
org.apache.commons.logging.LogFactory;<a name="line.29"></a>
+<span class="sourceLineNo">030</span>import 
org.apache.hadoop.hbase.classification.InterfaceAudience;<a name="line.30"></a>
+<span class="sourceLineNo">031</span>import 
org.apache.hadoop.conf.Configuration;<a name="line.31"></a>
+<span class="sourceLineNo">032</span>import org.apache.hadoop.fs.FileSystem;<a 
name="line.32"></a>
+<span class="sourceLineNo">033</span>import org.apache.hadoop.fs.Path;<a 
name="line.33"></a>
+<span class="sourceLineNo">034</span>import 
org.apache.hadoop.hbase.TableName;<a name="line.34"></a>
+<span class="sourceLineNo">035</span>import 
org.apache.hadoop.hbase.HRegionInfo;<a name="line.35"></a>
+<span class="sourceLineNo">036</span>import 
org.apache.hadoop.hbase.HTableDescriptor;<a name="line.36"></a>
+<span class="sourceLineNo">037</span>import 
org.apache.hadoop.hbase.ServerName;<a name="line.37"></a>
+<span class="sourceLineNo">038</span>import 
org.apache.hadoop.hbase.MetaTableAccessor;<a name="line.38"></a>
+<span class="sourceLineNo">039</span>import 
org.apache.hadoop.hbase.errorhandling.ForeignException;<a name="line.39"></a>
+<span class="sourceLineNo">040</span>import 
org.apache.hadoop.hbase.errorhandling.ForeignExceptionDispatcher;<a 
name="line.40"></a>
+<span class="sourceLineNo">041</span>import 
org.apache.hadoop.hbase.errorhandling.ForeignExceptionSnare;<a 
name="line.41"></a>
+<span class="sourceLineNo">042</span>import 
org.apache.hadoop.hbase.executor.EventHandler;<a name="line.42"></a>
+<span class="sourceLineNo">043</span>import 
org.apache.hadoop.hbase.executor.EventType;<a name="line.43"></a>
+<span class="sourceLineNo">044</span>import 
org.apache.hadoop.hbase.master.MasterServices;<a name="line.44"></a>
+<span class="sourceLineNo">045</span>import 
org.apache.hadoop.hbase.master.MetricsSnapshot;<a name="line.45"></a>
+<span class="sourceLineNo">046</span>import 
org.apache.hadoop.hbase.master.SnapshotSentinel;<a name="line.46"></a>
+<span class="sourceLineNo">047</span>import 
org.apache.hadoop.hbase.master.TableLockManager;<a name="line.47"></a>
+<span class="sourceLineNo">048</span>import 
org.apache.hadoop.hbase.master.TableLockManager.TableLock;<a name="line.48"></a>
+<span class="sourceLineNo">049</span>import 
org.apache.hadoop.hbase.monitoring.MonitoredTask;<a name="line.49"></a>
+<span class="sourceLineNo">050</span>import 
org.apache.hadoop.hbase.monitoring.TaskMonitor;<a name="line.50"></a>
+<span class="sourceLineNo">051</span>import 
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos.SnapshotDescription;<a 
name="line.51"></a>
+<span class="sourceLineNo">052</span>import 
org.apache.hadoop.hbase.snapshot.ClientSnapshotDescriptionUtils;<a 
name="line.52"></a>
+<span class="sourceLineNo">053</span>import 
org.apache.hadoop.hbase.snapshot.SnapshotCreationException;<a 
name="line.53"></a>
+<span class="sourceLineNo">054</span>import 
org.apache.hadoop.hbase.snapshot.SnapshotDescriptionUtils;<a name="line.54"></a>
+<span class="sourceLineNo">055</span>import 
org.apache.hadoop.hbase.snapshot.SnapshotManifest;<a name="line.55"></a>
+<span class="sourceLineNo">056</span>import 
org.apache.hadoop.hbase.util.FSUtils;<a name="line.56"></a>
+<span class="sourceLineNo">057</span>import 
org.apache.hadoop.hbase.util.Pair;<a name="line.57"></a>
+<span class="sourceLineNo">058</span>import 
org.apache.hadoop.hbase.zookeeper.MetaTableLocator;<a name="line.58"></a>
+<span class="sourceLineNo">059</span>import 
org.apache.zookeeper.KeeperException;<a name="line.59"></a>
+<span class="sourceLineNo">060</span><a name="line.60"></a>
+<span class="sourceLineNo">061</span>/**<a name="line.61"></a>
+<span class="sourceLineNo">062</span> * A handler for taking snapshots from 
the master.<a name="line.62"></a>
+<span class="sourceLineNo">063</span> *<a name="line.63"></a>
+<span class="sourceLineNo">064</span> * This is not a subclass of 
TableEventHandler because using that would incur an extra hbase:meta scan.<a 
name="line.64"></a>
+<span class="sourceLineNo">065</span> *<a name="line.65"></a>
+<span class="sourceLineNo">066</span> * The {@link #snapshotRegions(List)} 
call should get implemented for each snapshot flavor.<a name="line.66"></a>
+<span class="sourceLineNo">067</span> */<a name="line.67"></a>
+<span class="sourceLineNo">068</span>@InterfaceAudience.Private<a 
name="line.68"></a>
+<span class="sourceLineNo">069</span>public abstract class TakeSnapshotHandler 
extends EventHandler implements SnapshotSentinel,<a name="line.69"></a>
+<span class="sourceLineNo">070</span>    ForeignExceptionSnare {<a 
name="line.70"></a>
+<span class="sourceLineNo">071</span>  private static final Log LOG = 
LogFactory.getLog(TakeSnapshotHandler.class);<a name="line.71"></a>
+<span class="sourceLineNo">072</span><a name="line.72"></a>
+<span class="sourceLineNo">073</span>  private volatile boolean finished;<a 
name="line.73"></a>
+<span class="sourceLineNo">074</span><a name="line.74"></a>
+<span class="sourceLineNo">075</span>  // none of these should ever be null<a 
name="line.75"></a>
+<span class="sourceLineNo">076</span>  protected final MasterServices 
master;<a name="line.76"></a>
+<span class="sourceLineNo">077</span>  protected final MetricsSnapshot 
metricsSnapshot = new MetricsSnapshot();<a name="line.77"></a>
+<span class="sourceLineNo">078</span>  protected final SnapshotDescription 
snapshot;<a name="line.78"></a>
+<span class="sourceLineNo">079</span>  protected final Configuration conf;<a 
name="line.79"></a>
+<span class="sourceLineNo">080</span>  protected final FileSystem fs;<a 
name="line.80"></a>
+<span class="sourceLineNo">081</span>  protected final Path rootDir;<a 
name="line.81"></a>
+<span class="sourceLineNo">082</span>  private final Path snapshotDir;<a 
name="line.82"></a>
+<span class="sourceLineNo">083</span>  protected final Path workingDir;<a 
name="line.83"></a>
+<span class="sourceLineNo">084</span>  private final MasterSnapshotVerifier 
verifier;<a name="line.84"></a>
+<span class="sourceLineNo">085</span>  protected final 
ForeignExceptionDispatcher monitor;<a name="line.85"></a>
+<span class="sourceLineNo">086</span>  protected final TableLockManager 
tableLockManager;<a name="line.86"></a>
+<span class="sourceLineNo">087</span>  protected final TableLock tableLock;<a 
name="line.87"></a>
+<span class="sourceLineNo">088</span>  protected final MonitoredTask status;<a 
name="line.88"></a>
+<span class="sourceLineNo">089</span>  protected final TableName 
snapshotTable;<a name="line.89"></a>
+<span class="sourceLineNo">090</span>  protected final SnapshotManifest 
snapshotManifest;<a name="line.90"></a>
+<span class="sourceLineNo">091</span>  protected final SnapshotManager 
snapshotManager;<a name="line.91"></a>
 <span class="sourceLineNo">092</span><a name="line.92"></a>
-<span class="sourceLineNo">093</span>  /**<a name="line.93"></a>
-<span class="sourceLineNo">094</span>   * @param snapshot descriptor of the 
snapshot to take<a name="line.94"></a>
-<span class="sourceLineNo">095</span>   * @param masterServices master 
services provider<a name="line.95"></a>
-<span class="sourceLineNo">096</span>   */<a name="line.96"></a>
-<span class="sourceLineNo">097</span>  public 
TakeSnapshotHandler(SnapshotDescription snapshot, final MasterServices 
masterServices) {<a name="line.97"></a>
-<span class="sourceLineNo">098</span>    super(masterServices, 
EventType.C_M_SNAPSHOT_TABLE);<a name="line.98"></a>
-<span class="sourceLineNo">099</span>    assert snapshot != null : 
"SnapshotDescription must not be nul1";<a name="line.99"></a>
-<span class="sourceLineNo">100</span>    assert masterServices != null : 
"MasterServices must not be nul1";<a name="line.100"></a>
-<span class="sourceLineNo">101</span><a name="line.101"></a>
-<span class="sourceLineNo">102</span>    this.master = masterServices;<a 
name="line.102"></a>
-<span class="sourceLineNo">103</span>    this.snapshot = snapshot;<a 
name="line.103"></a>
-<span class="sourceLineNo">104</span>    this.snapshotTable = 
TableName.valueOf(snapshot.getTable());<a name="line.104"></a>
-<span class="sourceLineNo">105</span>    this.conf = 
this.master.getConfiguration();<a name="line.105"></a>
-<span class="sourceLineNo">106</span>    this.fs = 
this.master.getMasterFileSystem().getFileSystem();<a name="line.106"></a>
-<span class="sourceLineNo">107</span>    this.rootDir = 
this.master.getMasterFileSystem().getRootDir();<a name="line.107"></a>
-<span class="sourceLineNo">108</span>    this.snapshotDir = 
SnapshotDescriptionUtils.getCompletedSnapshotDir(snapshot, rootDir);<a 
name="line.108"></a>
-<span class="sourceLineNo">109</span>    this.workingDir = 
SnapshotDescriptionUtils.getWorkingSnapshotDir(snapshot, rootDir);<a 
name="line.109"></a>
-<span class="sourceLineNo">110</span>    this.monitor = new 
ForeignExceptionDispatcher(snapshot.getName());<a name="line.110"></a>
-<span class="sourceLineNo">111</span>    this.snapshotManifest = 
SnapshotManifest.create(conf, fs, workingDir, snapshot, monitor);<a 
name="line.111"></a>
-<span class="sourceLineNo">112</span><a name="line.112"></a>
-<span class="sourceLineNo">113</span>    this.tableLockManager = 
master.getTableLockManager();<a name="line.113"></a>
-<span class="sourceLineNo">114</span>    this.tableLock = 
this.tableLockManager.writeLock(<a name="line.114"></a>
-<span class="sourceLineNo">115</span>        snapshotTable,<a 
name="line.115"></a>
-<span class="sourceLineNo">116</span>        
EventType.C_M_SNAPSHOT_TABLE.toString());<a name="line.116"></a>
-<span class="sourceLineNo">117</span><a name="line.117"></a>
-<span class="sourceLineNo">118</span>    // prepare the verify<a 
name="line.118"></a>
-<span class="sourceLineNo">119</span>    this.verifier = new 
MasterSnapshotVerifier(masterServices, snapshot, rootDir);<a 
name="line.119"></a>
-<span class="sourceLineNo">120</span>    // update the running tasks<a 
name="line.120"></a>
-<span class="sourceLineNo">121</span>    this.status = 
TaskMonitor.get().createStatus(<a name="line.121"></a>
-<span class="sourceLineNo">122</span>      "Taking " + snapshot.getType() + " 
snapshot on table: " + snapshotTable);<a name="line.122"></a>
-<span class="sourceLineNo">123</span>  }<a name="line.123"></a>
-<span class="sourceLineNo">124</span><a name="line.124"></a>
-<span class="sourceLineNo">125</span>  private HTableDescriptor 
loadTableDescriptor()<a name="line.125"></a>
-<span class="sourceLineNo">126</span>      throws FileNotFoundException, 
IOException {<a name="line.126"></a>
-<span class="sourceLineNo">127</span>    HTableDescriptor htd =<a 
name="line.127"></a>
-<span class="sourceLineNo">128</span>      
this.master.getTableDescriptors().get(snapshotTable);<a name="line.128"></a>
-<span class="sourceLineNo">129</span>    if (htd == null) {<a 
name="line.129"></a>
-<span class="sourceLineNo">130</span>      throw new 
IOException("HTableDescriptor missing for " + snapshotTable);<a 
name="line.130"></a>
-<span class="sourceLineNo">131</span>    }<a name="line.131"></a>
-<span class="sourceLineNo">132</span>    return htd;<a name="line.132"></a>
-<span class="sourceLineNo">133</span>  }<a name="line.133"></a>
-<span class="sourceLineNo">134</span><a name="line.134"></a>
-<span class="sourceLineNo">135</span>  public TakeSnapshotHandler prepare() 
throws Exception {<a name="line.135"></a>
-<span class="sourceLineNo">136</span>    super.prepare();<a 
name="line.136"></a>
-<span class="sourceLineNo">137</span>    this.tableLock.acquire(); // after 
this, you should ensure to release this lock in<a name="line.137"></a>
-<span class="sourceLineNo">138</span>                              // case of 
exceptions<a name="line.138"></a>
-<span class="sourceLineNo">139</span>    boolean success = false;<a 
name="line.139"></a>
-<span class="sourceLineNo">140</span>    try {<a name="line.140"></a>
-<span class="sourceLineNo">141</span>      this.htd = loadTableDescriptor(); 
// check that .tableinfo is present<a name="line.141"></a>
-<span class="sourceLineNo">142</span>      success = true;<a 
name="line.142"></a>
-<span class="sourceLineNo">143</span>    } finally {<a name="line.143"></a>
-<span class="sourceLineNo">144</span>      if (!success) {<a 
name="line.144"></a>
-<span class="sourceLineNo">145</span>        releaseTableLock();<a 
name="line.145"></a>
-<span class="sourceLineNo">146</span>      }<a name="line.146"></a>
-<span class="sourceLineNo">147</span>    }<a name="line.147"></a>
-<span class="sourceLineNo">148</span><a name="line.148"></a>
-<span class="sourceLineNo">149</span>    return this;<a name="line.149"></a>
-<span class="sourceLineNo">150</span>  }<a name="line.150"></a>
-<span class="sourceLineNo">151</span><a name="line.151"></a>
-<span class="sourceLineNo">152</span>  /**<a name="line.152"></a>
-<span class="sourceLineNo">153</span>   * Execute the core common portions of 
taking a snapshot. The {@link #snapshotRegions(List)}<a name="line.153"></a>
-<span class="sourceLineNo">154</span>   * call should get implemented for each 
snapshot flavor.<a name="line.154"></a>
-<span class="sourceLineNo">155</span>   */<a name="line.155"></a>
-<span class="sourceLineNo">156</span>  @Override<a name="line.156"></a>
-<span class="sourceLineNo">157</span>  
@edu.umd.cs.findbugs.annotations.SuppressWarnings(value="REC_CATCH_EXCEPTION",<a
 name="line.157"></a>
-<span class="sourceLineNo">158</span>    justification="Intentional")<a 
name="line.158"></a>
-<span class="sourceLineNo">159</span>  public void process() {<a 
name="line.159"></a>
-<span class="sourceLineNo">160</span>    String msg = "Running " + 
snapshot.getType() + " table snapshot " + snapshot.getName() + " "<a 
name="line.160"></a>
-<span class="sourceLineNo">161</span>        + eventType + " on table " + 
snapshotTable;<a name="line.161"></a>
-<span class="sourceLineNo">162</span>    LOG.info(msg);<a name="line.162"></a>
-<span class="sourceLineNo">163</span>    status.setStatus(msg);<a 
name="line.163"></a>
-<span class="sourceLineNo">164</span>    try {<a name="line.164"></a>
-<span class="sourceLineNo">165</span>      // If regions move after this meta 
scan, the region specific snapshot should fail, triggering<a 
name="line.165"></a>
-<span class="sourceLineNo">166</span>      // an external exception that gets 
captured here.<a name="line.166"></a>
-<span class="sourceLineNo">167</span>      
SnapshotDescriptionUtils.createInProgressTag(workingDir, fs);<a 
name="line.167"></a>
-<span class="sourceLineNo">168</span>      // write down the snapshot info in 
the working directory<a name="line.168"></a>
-<span class="sourceLineNo">169</span>      
SnapshotDescriptionUtils.writeSnapshotInfo(snapshot, workingDir, fs);<a 
name="line.169"></a>
-<span class="sourceLineNo">170</span>      
snapshotManifest.addTableDescriptor(this.htd);<a name="line.170"></a>
-<span class="sourceLineNo">171</span>      monitor.rethrowException();<a 
name="line.171"></a>
+<span class="sourceLineNo">093</span>  protected HTableDescriptor htd;<a 
name="line.93"></a>
+<span class="sourceLineNo">094</span><a name="line.94"></a>
+<span class="sourceLineNo">095</span>  /**<a name="line.95"></a>
+<span class="sourceLineNo">096</span>   * @param snapshot descriptor of the 
snapshot to take<a name="line.96"></a>
+<span class="sourceLineNo">097</span>   * @param masterServices master 
services provider<a name="line.97"></a>
+<span class="sourceLineNo">098</span>   */<a name="line.98"></a>
+<span class="sourceLineNo">099</span>  public 
TakeSnapshotHandler(SnapshotDescription snapshot, final MasterServices 
masterServices,<a name="line.99"></a>
+<span class="sourceLineNo">100</span>                             final 
SnapshotManager snapshotManager) {<a name="line.100"></a>
+<span class="sourceLineNo">101</span>    super(masterServices, 
EventType.C_M_SNAPSHOT_TABLE);<a name="line.101"></a>
+<span class="sourceLineNo">102</span>    assert snapshot != null : 
"SnapshotDescription must not be nul1";<a name="line.102"></a>
+<span class="sourceLineNo">103</span>    assert masterServices != null : 
"MasterServices must not be nul1";<a name="line.103"></a>
+<span class="sourceLineNo">104</span><a name="line.104"></a>
+<span class="sourceLineNo">105</span>    this.master = masterServices;<a 
name="line.105"></a>
+<span class="sourceLineNo">106</span>    this.snapshot = snapshot;<a 
name="line.106"></a>
+<span class="sourceLineNo">107</span>    this.snapshotManager = 
snapshotManager;<a name="line.107"></a>
+<span class="sourceLineNo">108</span>    this.snapshotTable = 
TableName.valueOf(snapshot.getTable());<a name="line.108"></a>
+<span class="sourceLineNo">109</span>    this.conf = 
this.master.getConfiguration();<a name="line.109"></a>
+<span class="sourceLineNo">110</span>    this.fs = 
this.master.getMasterFileSystem().getFileSystem();<a name="line.110"></a>
+<span class="sourceLineNo">111</span>    this.rootDir = 
this.master.getMasterFileSystem().getRootDir();<a name="line.111"></a>
+<span class="sourceLineNo">112</span>    this.snapshotDir = 
SnapshotDescriptionUtils.getCompletedSnapshotDir(snapshot, rootDir);<a 
name="line.112"></a>
+<span class="sourceLineNo">113</span>    this.workingDir = 
SnapshotDescriptionUtils.getWorkingSnapshotDir(snapshot, rootDir);<a 
name="line.113"></a>
+<span class="sourceLineNo">114</span>    this.monitor = new 
ForeignExceptionDispatcher(snapshot.getName());<a name="line.114"></a>
+<span class="sourceLineNo">115</span>    this.snapshotManifest = 
SnapshotManifest.create(conf, fs, workingDir, snapshot, monitor);<a 
name="line.115"></a>
+<span class="sourceLineNo">116</span><a name="line.116"></a>
+<span class="sourceLineNo">117</span>    this.tableLockManager = 
master.getTableLockManager();<a name="line.117"></a>
+<span class="sourceLineNo">118</span>    this.tableLock = 
this.tableLockManager.writeLock(<a name="line.118"></a>
+<span class="sourceLineNo">119</span>        snapshotTable,<a 
name="line.119"></a>
+<span class="sourceLineNo">120</span>        
EventType.C_M_SNAPSHOT_TABLE.toString());<a name="line.120"></a>
+<span class="sourceLineNo">121</span><a name="line.121"></a>
+<span class="sourceLineNo">122</span>    // prepare the verify<a 
name="line.122"></a>
+<span class="sourceLineNo">123</span>    this.verifier = new 
MasterSnapshotVerifier(masterServices, snapshot, rootDir);<a 
name="line.123"></a>
+<span class="sourceLineNo">124</span>    // update the running tasks<a 
name="line.124"></a>
+<span class="sourceLineNo">125</span>    this.status = 
TaskMonitor.get().createStatus(<a name="line.125"></a>
+<span class="sourceLineNo">126</span>      "Taking " + snapshot.getType() + " 
snapshot on table: " + snapshotTable);<a name="line.126"></a>
+<span class="sourceLineNo">127</span>  }<a name="line.127"></a>
+<span class="sourceLineNo">128</span><a name="line.128"></a>
+<span class="sourceLineNo">129</span>  private HTableDescriptor 
loadTableDescriptor()<a name="line.129"></a>
+<span class="sourceLineNo">130</span>      throws FileNotFoundException, 
IOException {<a name="line.130"></a>
+<span class="sourceLineNo">131</span>    HTableDescriptor htd =<a 
name="line.131"></a>
+<span class="sourceLineNo">132</span>      
this.master.getTableDescriptors().get(snapshotTable);<a name="line.132"></a>
+<span class="sourceLineNo">133</span>    if (htd == null) {<a 
name="line.133"></a>
+<span class="sourceLineNo">134</span>      throw new 
IOException("HTableDescriptor missing for " + snapshotTable);<a 
name="line.134"></a>
+<span class="sourceLineNo">135</span>    }<a name="line.135"></a>
+<span class="sourceLineNo">136</span>    return htd;<a name="line.136"></a>
+<span class="sourceLineNo">137</span>  }<a name="line.137"></a>
+<span class="sourceLineNo">138</span><a name="line.138"></a>
+<span class="sourceLineNo">139</span>  public TakeSnapshotHandler prepare() 
throws Exception {<a name="line.139"></a>
+<span class="sourceLineNo">140</span>    super.prepare();<a 
name="line.140"></a>
+<span class="sourceLineNo">141</span>    this.tableLock.acquire(); // after 
this, you should ensure to release this lock in<a name="line.141"></a>
+<span class="sourceLineNo">142</span>                              // case of 
exceptions<a name="line.142"></a>
+<span class="sourceLineNo">143</span>    boolean success = false;<a 
name="line.143"></a>
+<span class="sourceLineNo">144</span>    try {<a name="line.144"></a>
+<span class="sourceLineNo">145</span>      this.htd = loadTableDescriptor(); 
// check that .tableinfo is present<a name="line.145"></a>
+<span class="sourceLineNo">146</span>      success = true;<a 
name="line.146"></a>
+<span class="sourceLineNo">147</span>    } finally {<a name="line.147"></a>
+<span class="sourceLineNo">148</span>      if (!success) {<a 
name="line.148"></a>
+<span class="sourceLineNo">149</span>        releaseTableLock();<a 
name="line.149"></a>
+<span class="sourceLineNo">150</span>      }<a name="line.150"></a>
+<span class="sourceLineNo">151</span>    }<a name="line.151"></a>
+<span class="sourceLineNo">152</span><a name="line.152"></a>
+<span class="sourceLineNo">153</span>    return this;<a name="line.153"></a>
+<span class="sourceLineNo">154</span>  }<a name="line.154"></a>
+<span class="sourceLineNo">155</span><a name="line.155"></a>
+<span class="sourceLineNo">156</span>  /**<a name="line.156"></a>
+<span class="sourceLineNo">157</span>   * Execute the core common portions of 
taking a snapshot. The {@link #snapshotRegions(List)}<a name="line.157"></a>
+<span class="sourceLineNo">158</span>   * call should get implemented for each 
snapshot flavor.<a name="line.158"></a>
+<span class="sourceLineNo">159</span>   */<a name="line.159"></a>
+<span class="sourceLineNo">160</span>  @Override<a name="line.160"></a>
+<span class="sourceLineNo">161</span>  
@edu.umd.cs.findbugs.annotations.SuppressWarnings(value="REC_CATCH_EXCEPTION",<a
 name="line.161"></a>
+<span class="sourceLineNo">162</span>    justification="Intentional")<a 
name="line.162"></a>
+<span class="sourceLineNo">163</span>  public void process() {<a 
name="line.163"></a>
+<span class="sourceLineNo">164</span>    String msg = "Running " + 
snapshot.getType() + " table snapshot " + snapshot.getName() + " "<a 
name="line.164"></a>
+<span class="sourceLineNo">165</span>        + eventType + " on table " + 
snapshotTable;<a name="line.165"></a>
+<span class="sourceLineNo">166</span>    LOG.info(msg);<a name="line.166"></a>
+<span class="sourceLineNo">167</span>    ReentrantLock lock = 
snapshotManager.getLocks().acquireLock(snapshot.getName());<a 
name="line.167"></a>
+<span class="sourceLineNo">168</span>    status.setStatus(msg);<a 
name="line.168"></a>
+<span class="sourceLineNo">169</span>    try {<a name="line.169"></a>
+<span class="sourceLineNo">170</span>      // If regions move after this meta 
scan, the region specific snapshot should fail, triggering<a 
name="line.170"></a>
+<span class="sourceLineNo">171</span>      // an external exception that gets 
captured here.<a name="line.171"></a>
 <span class="sourceLineNo">172</span><a name="line.172"></a>
-<span class="sourceLineNo">173</span>      List&lt;Pair&lt;HRegionInfo, 
ServerName&gt;&gt; regionsAndLocations;<a name="line.173"></a>
-<span class="sourceLineNo">174</span>      if 
(TableName.META_TABLE_NAME.equals(snapshotTable)) {<a name="line.174"></a>
-<span class="sourceLineNo">175</span>        regionsAndLocations = new 
MetaTableLocator().getMetaRegionsAndLocations(<a name="line.175"></a>
-<span class="sourceLineNo">176</span>          server.getZooKeeper());<a 
name="line.176"></a>
-<span class="sourceLineNo">177</span>      } else {<a name="line.177"></a>
-<span class="sourceLineNo">178</span>        regionsAndLocations = 
MetaTableAccessor.getTableRegionsAndLocations(<a name="line.178"></a>
-<span class="sourceLineNo">179</span>          server.getConnection(), 
snapshotTable, false);<a name="line.179"></a>
-<span class="sourceLineNo">180</span>      }<a name="line.180"></a>
-<span class="sourceLineNo">181</span><a name="line.181"></a>
-<span class="sourceLineNo">182</span>      // run the snapshot<a 
name="line.182"></a>
-<span class="sourceLineNo">183</span>      
snapshotRegions(regionsAndLocations);<a name="line.183"></a>
-<span class="sourceLineNo">184</span>      monitor.rethrowException();<a 
name="line.184"></a>
-<span class="sourceLineNo">185</span><a name="line.185"></a>
-<span class="sourceLineNo">186</span>      // extract each pair to separate 
lists<a name="line.186"></a>
-<span class="sourceLineNo">187</span>      Set&lt;String&gt; serverNames = new 
HashSet&lt;String&gt;();<a name="line.187"></a>
-<span class="sourceLineNo">188</span>      for (Pair&lt;HRegionInfo, 
ServerName&gt; p : regionsAndLocations) {<a name="line.188"></a>
-<span class="sourceLineNo">189</span>        if (p != null &amp;&amp; 
p.getFirst() != null &amp;&amp; p.getSecond() != null) {<a name="line.189"></a>
-<span class="sourceLineNo">190</span>          HRegionInfo hri = 
p.getFirst();<a name="line.190"></a>
-<span class="sourceLineNo">191</span>          if (hri.isOffline() &amp;&amp; 
(hri.isSplit() || hri.isSplitParent())) continue;<a name="line.191"></a>
-<span class="sourceLineNo">192</span>          
serverNames.add(p.getSecond().toString());<a name="line.192"></a>
-<span class="sourceLineNo">193</span>        }<a name="line.193"></a>
-<span class="sourceLineNo">194</span>      }<a name="line.194"></a>
-<span class="sourceLineNo">195</span><a name="line.195"></a>
-<span class="sourceLineNo">196</span>      // flush the in-memory state, and 
write the single manifest<a name="line.196"></a>
-<span class="sourceLineNo">197</span>      status.setStatus("Consolidate 
snapshot: " + snapshot.getName());<a name="line.197"></a>
-<span class="sourceLineNo">198</span>      snapshotManifest.consolidate();<a 
name="line.198"></a>
-<span class="sourceLineNo">199</span><a name="line.199"></a>
-<span class="sourceLineNo">200</span>      // verify the snapshot is valid<a 
name="line.200"></a>
-<span class="sourceLineNo">201</span>      status.setStatus("Verifying 
snapshot: " + snapshot.getName());<a name="line.201"></a>
-<span class="sourceLineNo">202</span>      
verifier.verifySnapshot(this.workingDir, serverNames);<a name="line.202"></a>
-<span class="sourceLineNo">203</span><a name="line.203"></a>
-<span class="sourceLineNo">204</span>      // complete the snapshot, 
atomically moving from tmp to .snapshot dir.<a name="line.204"></a>
-<span class="sourceLineNo">205</span>      completeSnapshot(this.snapshotDir, 
this.workingDir, this.fs);<a name="line.205"></a>
-<span class="sourceLineNo">206</span>      msg = "Snapshot " + 
snapshot.getName() + " of table " + snapshotTable + " completed";<a 
name="line.206"></a>
-<span class="sourceLineNo">207</span>      status.markComplete(msg);<a 
name="line.207"></a>
-<span class="sourceLineNo">208</span>      LOG.info(msg);<a 
name="line.208"></a>
-<span class="sourceLineNo">209</span>      
metricsSnapshot.addSnapshot(status.getCompletionTimestamp() - 
status.getStartTime());<a name="line.209"></a>
-<span class="sourceLineNo">210</span>    } catch (Exception e) { // FindBugs: 
REC_CATCH_EXCEPTION<a name="line.210"></a>
-<span class="sourceLineNo">211</span>      status.abort("Failed to complete 
snapshot " + snapshot.getName() + " on table " +<a name="line.211"></a>
-<span class="sourceLineNo">212</span>          snapshotTable + " because " + 
e.getMessage());<a name="line.212"></a>
-<span class="sourceLineNo">213</span>      String reason = "Failed taking 
snapshot " + ClientSnapshotDescriptionUtils.toString(snapshot)<a 
name="line.213"></a>
-<span class="sourceLineNo">214</span>          + " due to exception:" + 
e.getMessage();<a name="line.214"></a>
-<span class="sourceLineNo">215</span>      LOG.error(reason, e);<a 
name="line.215"></a>
-<span class="sourceLineNo">216</span>      ForeignException ee = new 
ForeignException(reason, e);<a name="line.216"></a>
-<span class="sourceLineNo">217</span>      monitor.receive(ee);<a 
name="line.217"></a>
-<span class="sourceLineNo">218</span>      // need to mark this completed to 
close off and allow cleanup to happen.<a name="line.218"></a>
-<span class="sourceLineNo">219</span>      cancel(reason);<a 
name="line.219"></a>
-<span class="sourceLineNo">220</span>    } finally {<a name="line.220"></a>
-<span class="sourceLineNo">221</span>      LOG.debug("Launching cleanup of 
working dir:" + workingDir);<a name="line.221"></a>
-<span class="sourceLineNo">222</span>      try {<a name="line.222"></a>
-<span class="sourceLineNo">223</span>        // if the working dir is still 
present, the snapshot has failed.  it is present we delete<a 
name="line.223"></a>
-<span class="sourceLineNo">224</span>        // it.<a name="line.224"></a>
-<span class="sourceLineNo">225</span>        if (fs.exists(workingDir) 
&amp;&amp; !this.fs.delete(workingDir, true)) {<a name="line.225"></a>
-<span class="sourceLineNo">226</span>          LOG.error("Couldn't delete 
snapshot working directory:" + workingDir);<a name="line.226"></a>
-<span class="sourceLineNo">227</span>        }<a name="line.227"></a>
-<span class="sourceLineNo">228</span>      } catch (IOException e) {<a 
name="line.228"></a>
-<span class="sourceLineNo">229</span>        LOG.error("Couldn't delete 
snapshot working directory:" + workingDir);<a name="line.229"></a>
-<span class="sourceLineNo">230</span>      }<a name="line.230"></a>
-<span class="sourceLineNo">231</span>      releaseTableLock();<a 
name="line.231"></a>
-<span class="sourceLineNo">232</span>    }<a name="line.232"></a>
-<span class="sourceLineNo">233</span>  }<a name="line.233"></a>
-<span class="sourceLineNo">234</span><a name="line.234"></a>
-<span class="sourceLineNo">235</span>  protected void releaseTableLock() {<a 
name="line.235"></a>
-<span class="sourceLineNo">236</span>    if (this.tableLock != null) {<a 
name="line.236"></a>
-<span class="sourceLineNo">237</span>      try {<a name="line.237"></a>
-<span class="sourceLineNo">238</span>        this.tableLock.release();<a 
name="line.238"></a>
-<span class="sourceLineNo">239</span>      } catch (IOException ex) {<a 
name="line.239"></a>
-<span class="sourceLineNo">240</span>        LOG.warn("Could not release the 
table lock", ex);<a name="line.240"></a>
-<span class="sourceLineNo">241</span>      }<a name="line.241"></a>
-<span class="sourceLineNo">242</span>    }<a name="line.242"></a>
-<span class="sourceLineNo">243</span>  }<a name="line.243"></a>
-<span class="sourceLineNo">244</span><a name="line.244"></a>
-<span class="sourceLineNo">245</span>  /**<a name="line.245"></a>
-<span class="sourceLineNo">246</span>   * Reset the manager to allow another 
snapshot to proceed<a name="line.246"></a>
-<span class="sourceLineNo">247</span>   *<a name="line.247"></a>
-<span class="sourceLineNo">248</span>   * @param snapshotDir final path of the 
snapshot<a name="line.248"></a>
-<span class="sourceLineNo">249</span>   * @param workingDir directory where 
the in progress snapshot was built<a name="line.249"></a>
-<span class="sourceLineNo">250</span>   * @param fs {@link FileSystem} where 
the snapshot was built<a name="line.250"></a>
-<span class="sourceLineNo">251</span>   * @throws SnapshotCreationException if 
the snapshot could not be moved<a name="line.251"></a>
-<span class="sourceLineNo">252</span>   * @throws IOException the filesystem 
could not be reached<a name="line.252"></a>
-<span class="sourceLineNo">253</span>   */<a name="line.253"></a>
-<span class="sourceLineNo">254</span>  public void completeSnapshot(Path 
snapshotDir, Path workingDir, FileSystem fs)<a name="line.254"></a>
-<span class="sourceLineNo">255</span>      throws SnapshotCreationException, 
IOException {<a name="line.255"></a>
-<span class="sourceLineNo">256</span>    LOG.debug("Sentinel is done, just 
moving the snapshot from " + workingDir + " to "<a name="line.256"></a>
-<span class="sourceLineNo">257</span>        + snapshotDir);<a 
name="line.257"></a>
-<span class="sourceLineNo">258</span>    if (!fs.rename(workingDir, 
snapshotDir)) {<a name="line.258"></a>
-<span class="sourceLineNo">259</span>      throw new 
SnapshotCreationException("Failed to move working directory(" + workingDir<a 
name="line.259"></a>
-<span class="sourceLineNo">260</span>          + ") to completed directory(" + 
snapshotDir + ").");<a name="line.260"></a>
-<span class="sourceLineNo">261</span>    }<a name="line.261"></a>
-<span class="sourceLineNo">262</span>    finished = true;<a 
name="line.262"></a>
-<span class="sourceLineNo">263</span>  }<a name="line.263"></a>
-<span class="sourceLineNo">264</span><a name="line.264"></a>
-<span class="sourceLineNo">265</span>  /**<a name="line.265"></a>
-<span class="sourceLineNo">266</span>   * Snapshot the specified regions<a 
name="line.266"></a>
-<span class="sourceLineNo">267</span>   */<a name="line.267"></a>
-<span class="sourceLineNo">268</span>  protected abstract void 
snapshotRegions(List&lt;Pair&lt;HRegionInfo, ServerName&gt;&gt; regions)<a 
name="line.268"></a>
-<span class="sourceLineNo">269</span>      throws IOException, 
KeeperException;<a name="line.269"></a>
+<span class="sourceLineNo">173</span>      // write down the snapshot info in 
the working directory<a name="line.173"></a>
+<span class="sourceLineNo">174</span>      
SnapshotDescriptionUtils.writeSnapshotInfo(snapshot, workingDir, fs);<a 
name="line.174"></a>
+<span class="sourceLineNo">175</span>      
snapshotManifest.addTableDescriptor(this.htd);<a name="line.175"></a>
+<span class="sourceLineNo">176</span>      monitor.rethrowException();<a 
name="line.176"></a>
+<span class="sourceLineNo">177</span><a name="line.177"></a>
+<span class="sourceLineNo">178</span>      List&lt;Pair&lt;HRegionInfo, 
ServerName&gt;&gt; regionsAndLocations;<a name="line.178"></a>
+<span class="sourceLineNo">179</span>      if 
(TableName.META_TABLE_NAME.equals(snapshotTable)) {<a name="line.179"></a>
+<span class="sourceLineNo">180</span>        regionsAndLocations = new 
MetaTableLocator().getMetaRegionsAndLocations(<a name="line.180"></a>
+<span class="sourceLineNo">181</span>          server.getZooKeeper());<a 
name="line.181"></a>
+<span class="sourceLineNo">182</span>      } else {<a name="line.182"></a>
+<span class="sourceLineNo">183</span>        regionsAndLocations = 
MetaTableAccessor.getTableRegionsAndLocations(<a name="line.183"></a>
+<span class="sourceLineNo">184</span>          server.getConnection(), 
snapshotTable, false);<a name="line.184"></a>
+<span class="sourceLineNo">185</span>      }<a name="line.185"></a>
+<span class="sourceLineNo">186</span><a name="line.186"></a>
+<span class="sourceLineNo">187</span>      // run the snapshot<a 
name="line.187"></a>
+<span class="sourceLineNo">188</span>      
snapshotRegions(regionsAndLocations);<a name="line.188"></a>
+<span class="sourceLineNo">189</span>      monitor.rethrowException();<a 
name="line.189"></a>
+<span class="sourceLineNo">190</span><a name="line.190"></a>
+<span class="sourceLineNo">191</span>      // extract each pair to separate 
lists<a name="line.191"></a>
+<span class="sourceLineNo">192</span>      Set&lt;String&gt; serverNames = new 
HashSet&lt;String&gt;();<a name="line.192"></a>
+<span class="sourceLineNo">193</span>      for (Pair&lt;HRegionInfo, 
ServerName&gt; p : regionsAndLocations) {<a name="line.193"></a>
+<span class="sourceLineNo">194</span>        if (p != null &amp;&amp; 
p.getFirst() != null &amp;&amp; p.getSecond() != null) {<a name="line.194"></a>
+<span class="sourceLineNo">195</span>          HRegionInfo hri = 
p.getFirst();<a name="line.195"></a>
+<span class="sourceLineNo">196</span>          if (hri.isOffline() &amp;&amp; 
(hri.isSplit() || hri.isSplitParent())) continue;<a name="line.196"></a>
+<span class="sourceLineNo">197</span>          
serverNames.add(p.getSecond().toString());<a name="line.197"></a>
+<span class="sourceLineNo">198</span>        }<a name="line.198"></a>
+<span class="sourceLineNo">199</span>      }<a name="line.199"></a>
+<span class="sourceLineNo">200</span><a name="line.200"></a>
+<span class="sourceLineNo">201</span>      // flush the in-memory state, and 
write the single manifest<a name="line.201"></a>
+<span class="sourceLineNo">202</span>      status.setStatus("Consolidate 
snapshot: " + snapshot.getName());<a name="line.202"></a>
+<span class="sourceLineNo">203</span>      snapshotManifest.consolidate();<a 
name="line.203"></a>
+<span class="sourceLineNo">204</span><a name="line.204"></a>
+<span class="sourceLineNo">205</span>      // verify the snapshot is valid<a 
name="line.205"></a>
+<span class="sourceLineNo">206</span>      status.setStatus("Verifying 
snapshot: " + snapshot.getName());<a name="line.206"></a>
+<span class="sourceLineNo">207</span>      
verifier.verifySnapshot(this.workingDir, serverNames);<a name="line.207"></a>
+<span class="sourceLineNo">208</span><a name="line.208"></a>
+<span class="sourceLineNo">209</span>      // complete the snapshot, 
atomically moving from tmp to .snapshot dir.<a name="line.209"></a>
+<span class="sourceLineNo">210</span>      completeSnapshot(this.snapshotDir, 
this.workingDir, this.fs);<a name="line.210"></a>
+<span class="sourceLineNo">211</span>      msg = "Snapshot " + 
snapshot.getName() + " of table " + snapshotTable + " completed";<a 
name="line.211"></a>
+<span class="sourceLineNo">212</span>      status.markComplete(msg);<a 
name="line.212"></a>
+<span class="sourceLineNo">213</span>      LOG.info(msg);<a 
name="line.213"></a>
+<span class="sourceLineNo">214</span>      
metricsSnapshot.addSnapshot(status.getCompletionTimestamp() - 
status.getStartTime());<a name="line.214"></a>
+<span class="sourceLineNo">215</span>    } catch (Exception e) { // FindBugs: 
REC_CATCH_EXCEPTION<a name="line.215"></a>
+<span class="sourceLineNo">216</span>      status.abort("Failed to complete 
snapshot " + snapshot.getName() + " on table " +<a name="line.216"></a>
+<span class="sourceLineNo">217</span>          snapshotTable + " because " + 
e.getMessage());<a name="line.217"></a>
+<span class="sourceLineNo">218</span>      String reason = "Failed taking 
snapshot " + ClientSnapshotDescriptionUtils.toString(snapshot)<a 
name="line.218"></a>
+<span class="sourceLineNo">219</span>          + " due to exception:" + 
e.getMessage();<a name="line.219"></a>
+<span class="sourceLineNo">220</span>      LOG.error(reason, e);<a 
name="line.220"></a>
+<span class="sourceLineNo">221</span>      ForeignException ee = new 
ForeignException(reason, e);<a name="line.221"></a>
+<span class="sourceLineNo">222</span>      monitor.receive(ee);<a 
name="line.222"></a>
+<span class="sourceLineNo">223</span>      // need to mark this completed to 
close off and allow cleanup to happen.<a name="line.223"></a>
+<span class="sourceLineNo">224</span>      cancel(reason);<a 
name="line.224"></a>
+<span class="sourceLineNo">225</span>    } finally {<a name="line.225"></a>
+<span class="sourceLineNo">226</span>      LOG.debug("Launching cleanup of 
working dir:" + workingDir);<a name="line.226"></a>
+<span class="sourceLineNo">227</span>      try {<a name="line.227"></a>
+<span class="sourceLineNo">228</span>        // if the working dir is still 
present, the snapshot has failed.  it is present we delete<a 
name="line.228"></a>
+<span class="sourceLineNo">229</span>        // it.<a name="line.229"></a>
+<span class="sourceLineNo">230</span>        if (fs.exists(workingDir) 
&amp;&amp; !this.fs.delete(workingDir, true)) {<a name="line.230"></a>
+<span class="sourceLineNo">231</span>          LOG.error("Couldn't delete 
snapshot working directory:" + workingDir);<a name="line.231"></a>
+<span class="sourceLineNo">232</span>        }<a name="line.232"></a>
+<span class="sourceLineNo">233</span>      } catch (IOException e) {<a 
name="line.233"></a>
+<span class="sourceLineNo">234</span>        LOG.error("Couldn't delete 
snapshot working directory:" + workingDir);<a name="line.234"></a>
+<span class="sourceLineNo">235</span>      }<a name="line.235"></a>
+<span class="sourceLineNo">236</span>      lock.unlock();<a 
name="line.236"></a>
+<span class="sourceLineNo">237</span>      releaseTableLock();<a 
name="line.237"></a>
+<span class="sourceLineNo">238</span>    }<a name="line.238"></a>
+<span class="sourceLineNo">239</span>  }<a name="line.239"></a>
+<span class="sourceLineNo">240</span><a name="line.240"></a>
+<span class="sourceLineNo">241</span>  protected void releaseTableLock() {<a 
name="line.241"></a>
+<span class="sourceLineNo">242</span>    if (this.tableLock != null) {<a 
name="line.242"></a>
+<span class="sourceLineNo">243</span>      try {<a name="line.243"></a>
+<span class="sourceLineNo">244</span>        this.tableLock.release();<a 
name="line.244"></a>
+<span class="sourceLineNo">245</span>      } catch (IOException ex) {<a 
name="line.245"></a>
+<span class="sourceLineNo">246</span>        LOG.warn("Could not release the 
table lock", ex);<a name="line.246"></a>
+<span class="sourceLineNo">247</span>      }<a name="line.247"></a>
+<span class="sourceLineNo">248</span>    }<a name="line.248"></a>
+<span class="sourceLineNo">249</span>  }<a name="line.249"></a>
+<span class="sourceLineNo">250</span><a name="line.250"></a>
+<span class="sourceLineNo">251</span>  /**<a name="line.251"></a>
+<span class="sourceLineNo">252</span>   * Reset the manager to allow another 
snapshot to proceed<a name="line.252"></a>
+<span class="sourceLineNo">253</span>   *<a name="line.253"></a>
+<span class="sourceLineNo">254</span>   * @param snapshotDir final path of the 
snapshot<a name="line.254"></a>
+<span class="sourceLineNo">255</span>   * @param workingDir directory where 
the in progress snapshot was built<a name="line.255"></a>
+<span class="sourceLineNo">256</span>   * @param fs {@link FileSystem} where 
the snapshot was built<a name="line.256"></a>
+<span class="sourceLineNo">257</span>   * @throws SnapshotCreationException if 
the snapshot could not be moved<a name="line.257"></a>
+<span class="sourceLineNo">258</span>   * @throws IOException the filesystem 
could not be reached<a name="line.258"></a>
+<span class="sourceLineNo">259</span>   */<a name="line.259"></a>
+<span class="sourceLineNo">260</span>  public void completeSnapshot(Path 
snapshotDir, Path workingDir, FileSystem fs)<a name="line.260"></a>
+<span class="sourceLineNo">261</span>      throws SnapshotCreationException, 
IOException {<a name="line.261"></a>
+<span class="sourceLineNo">262</span>    LOG.debug("Sentinel is done, just 
moving the snapshot from " + workingDir + " to "<a name="line.262"></a>
+<span class="sourceLineNo">263</span>        + snapshotDir);<a 
name="line.263"></a>
+<span class="sourceLineNo">264</span>    if (!fs.rename(workingDir, 
snapshotDir)) {<a name="line.264"></a>
+<span class="sourceLineNo">265</span>      throw new 
SnapshotCreationException("Failed to move working directory(" + workingDir<a 
name="line.265"></a>
+<span class="sourceLineNo">266</span>          + ") to completed directory(" + 
snapshotDir + ").");<a name="line.266"></a>
+<span class="sourceLineNo">267</span>    }<a name="line.267"></a>
+<span class="sourceLineNo">268</span>    finished = true;<a 
name="line.268"></a>
+<span class="sourceLineNo">269</span>  }<a name="line.269"></a>
 <span class="sourceLineNo">270</span><a name="line.270"></a>
 <span class="sourceLineNo">271</span>  /**<a name="line.271"></a>
-<span class="sourceLineNo">272</span>   * Take a snapshot of the specified 
disabled region<a name="line.272"></a>
+<span class="sourceLineNo">272</span>   * Snapshot the specified regions<a 
name="line.272"></a>
 <span class="sourceLineNo">273</span>   */<a name="line.273"></a>
-<span class="sourceLineNo">274</span>  protected void 
snapshotDisabledRegion(final HRegionInfo regionInfo)<a name="line.274"></a>
-<span class="sourceLineNo">275</span>      throws IOException {<a 
name="line.275"></a>
-<span class="sourceLineNo">276</span>    
snapshotManifest.addRegion(FSUtils.getTableDir(rootDir, snapshotTable), 
regionInfo);<a name="line.276"></a>
-<span class="sourceLineNo">277</span>    monitor.rethrowException();<a 
name="line.277"></a>
-<span class="sourceLineNo">278</span>    status.setStatus("Completed 
referencing HFiles for offline region " + regionInfo.toString() +<a 
name="line.278"></a>
-<span class="sourceLineNo">279</span>        " of table: " + snapshotTable);<a 
name="line.279"></a>
-<span class="sourceLineNo">280</span>  }<a name="line.280"></a>
-<span class="sourceLineNo">281</span><a name="line.281"></a>
-<span class="sourceLineNo">282</span>  @Override<a name="line.282"></a>
-<span class="sourceLineNo">283</span>  public void cancel(String why) {<a 
name="line.283"></a>
-<span class="sourceLineNo">284</span>    if (finished) return;<a 
name="line.284"></a>
-<span class="sourceLineNo">285</span><a name="line.285"></a>
-<span class="sourceLineNo">286</span>    this.finished = true;<a 
name="line.286"></a>
-<span class="sourceLineNo">287</span>    LOG.info("Stop taking snapshot=" + 
ClientSnapshotDescriptionUtils.toString(snapshot) +<a name="line.287"></a>
-<span class="sourceLineNo">288</span>        " because: " + why);<a 
name="line.288"></a>
-<span class="sourceLineNo">289</span>    CancellationException ce = new 
CancellationException(why);<a name="line.289"></a>
-<span class="sourceLineNo">290</span>    monitor.receive(new 
ForeignException(master.getServerName().toString(), ce));<a name="line.290"></a>
-<span class="sourceLineNo">291</span>  }<a name="line.291"></a>
-<span class="sourceLineNo">292</span><a name="line.292"></a>
-<span class="sourceLineNo">293</span>  @Override<a name="line.293"></a>
-<span class="sourceLineNo">294</span>  public boolean isFinished() {<a 
name="line.294"></a>
-<span class="sourceLineNo">295</span>    return finished;<a 
name="line.295"></a>
-<span class="sourceLineNo">296</span>  }<a name="line.296"></a>
-<span class="sourceLineNo">297</span><a name="line.297"></a>
-<span class="sourceLineNo">298</span>  @Override<a name="line.298"></a>
-<span class="sourceLineNo">299</span>  public long getCompletionTimestamp() 
{<a name="line.299"></a>
-<span class="sourceLineNo">300</span>    return 
this.status.getCompletionTimestamp();<a name="line.300"></a>
-<span class="sourceLineNo">301</span>  }<a name="line.301"></a>
-<span class="sourceLineNo">302</span><a name="line.302"></a>
-<span class="sourceLineNo">303</span>  @Override<a name="line.303"></a>
-<span class="sourceLineNo">304</span>  public SnapshotDescription 
getSnapshot() {<a name="line.304"></a>
-<span class="sourceLineNo">305</span>    return snapshot;<a 
name="line.305"></a>
-<span class="sourceLineNo">306</span>  }<a name="line.306"></a>
-<span class="sourceLineNo">307</span><a name="line.307"></a>
-<span class="sourceLineNo">308</span>  @Override<a name="line.308"></a>
-<span class="sourceLineNo">309</span>  public ForeignException 
getExceptionIfFailed() {<a name="line.309"></a>
-<span class="sourceLineNo">310</span>    return monitor.getException();<a 
name="line.310"></a>
-<span class="sourceLineNo">311</span>  }<a name="line.311"></a>
-<span class="sourceLineNo">312</span><a name="line.312"></a>
-<span class="sourceLineNo">313</span>  @Override<a name="line.313"></a>
-<span class="sourceLineNo">314</span>  public void rethrowExceptionIfFailed() 
throws ForeignException {<a name="line.314"></a>
-<span class="sourceLineNo">315</span>    monitor.rethrowException();<a 
name="line.315"></a>
-<span class="sourceLineNo">316</span>  }<a name="line.316"></a>
-<span class="sourceLineNo">317</span><a name="line.317"></a>
-<span class="sourceLineNo">318</span>  @Override<a name="line.318"></a>
-<span class="sourceLineNo">319</span>  public void rethrowException() throws 
ForeignException {<a name="line.319"></a>
-<span class="sourceLineNo">320</span>    monitor.rethrowException();<a 
name="line.320"></a>
-<span class="sourceLineNo">321</span>  }<a name="line.321"></a>
-<span class="sourceLineNo">322</span><a name="line.322"></a>
-<span class="sourceLineNo">323</span>  @Override<a name="line.323"></a>
-<span class="sourceLineNo">324</span>  public boolean hasException() {<a 
name="line.324"></a>
-<span class="sourceLineNo">325</span>    return monitor.hasException();<a 
name="line.325"></a>
-<span class="sourceLineNo">326</span>  }<a name="line.326"></a>
-<span class="sourceLineNo">327</span><a name="line.327"></a>
-<span class="sourceLineNo">328</span>  @Override<a name="line.328"></a>
-<span class="sourceLineNo">329</span>  public ForeignException getException() 
{<a name="line.329"></a>
-<span class="sourceLineNo">330</span>    return monitor.getException();<a 
name="line.330"></a>
-<span class="sourceLineNo">331</span>  }<a name="line.331"></a>
-<span class="sourceLineNo">332</span><a name="line.332"></a>
-<span class="sourceLineNo">333</span>}<a name="line.333"></a>
+<span class="sourceLineNo">274</span>  protected abstract void 
snapshotRegions(List&lt;Pair&lt;HRegionInfo, ServerName&gt;&gt; regions)<a 
name="line.274"></a>
+<span class="sourceLineNo">275</span>      throws IOException, 
KeeperException;<a name="line.275"></a>
+<span class="sourceLineNo">276</span><a name="line.276"></a>
+<span class="sourceLineNo">277</span>  /**<a name="line.277"></a>
+<span class="sourceLineNo">278</span>   * Take a snapshot of the specified 
disabled region<a name="line.278"></a>
+<span class="sourceLineNo">279</span>   */<a name="line.279"></a>
+<span class="sourceLineNo">280</span>  protected void 
snapshotDisabledRegion(final HRegionInfo regionInfo)<a name="line.280"></a>
+<span class="sourceLineNo">281</span>      throws IOException {<a 
name="line.281"></a>
+<span class="sourceLineNo">282</span>    
snapshotManifest.addRegion(FSUtils.getTableDir(rootDir, snapshotTable), 
regionInfo);<a name="line.282"></a>
+<span class="sourceLineNo">283</span>    monitor.rethrowException();<a 
name="line.283"></a>
+<span class="sourceLineNo">284</span>    status.setStatus("Completed 
referencing HFiles for offline region " + regionInfo.toString() +<a 
name="line.284"></a>
+<span class="sourceLineNo">285</span>        " of table: " + snapshotTable);<a 
name="line.285"></a>
+<span class="sourceLineNo">286</span>  }<a name="line.286"></a>
+<span class="sourceLineNo">287</span><a name="line.287"></a>
+<span class="sourceLineNo">288</span>  @Override<a name="line.288"></a>
+<span class="sourceLineNo">289</span>  public void cancel(String why) {<a 
name="line.289"></a>
+<span class="sourceLineNo">290</span>    if (finished) return;<a 
name="line.290"></a>
+<span class="sourceLineNo">291</span><a name="line.291"></a>
+<span class="sourceLineNo">292</span>    this.finished = true;<a 
name="line.292"></a>
+<span class="sourceLineNo">293</span>    LOG.info("Stop taking snapshot=" + 
ClientSnapshotDescriptionUtils.toString(snapshot) +<a name="line.293"></a>
+<span class="sourceLineNo">294</span>        " because: " + why);<a 
name="line.294"></a>
+<span class="sourceLineNo">295</span>    CancellationException ce = new 
CancellationException(why);<a name="line.295"></a>
+<span class="sourceLineNo">296</span>    monitor.receive(new 
ForeignException(master.getServerName().toString(), ce));<a name="line.296"></a>
+<span class="sourceLineNo">297</span>  }<a name="line.297"></a>
+<span class="sourceLineNo">298</span><a name="line.298"></a>
+<span class="sourceLineNo">299</span>  @Override<a name="line.299"></a>
+<span class="sourceLineNo">300</span>  public boolean isFinished() {<a 
name="line.300"></a>
+<span class="sourceLineNo">301</span>    return finished;<a 
name="line.301"></a>
+<span class="sourceLineNo">302</span>  }<a name="line.302"></a>
+<span class="sourceLineNo">303</span><a name="line.303"></a>
+<span class="sourceLineNo">304</span>  @Override<a name="line.304"></a>
+<span class="sourceLineNo">305</span>  public long getCompletionTimestamp() 
{<a name="line.305"></a>
+<span class="sourceLineNo">306</span>    return 
this.status.getCompletionTimestamp();<a name="line.306"></a>
+<span class="sourceLineNo">307</span>  }<a name="line.307"></a>
+<span class="sourceLineNo">308</span><a name="line.308"></a>
+<span class="sourceLineNo">309</span>  @Override<a name="line.309"></a>
+<span class="sourceLineNo">310</span>  public SnapshotDescription 
getSnapshot() {<a name="line.310"></a>
+<span class="sourceLineNo">311</span>    return snapshot;<a 
name="line.311"></a>
+<span class="sourceLineNo">312</span>  }<a name="line.312"></a>
+<span class="sourceLineNo">313</span><a name="line.313"></a>
+<span class="sourceLineNo">314</span>  @Override<a name="line.314"></a>
+<span class="sourceLineNo">315</span>  public ForeignException 
getExceptionIfFailed() {<a name="line.315"></a>
+<span class="sourceLineNo">316</span>    return monitor.getException();<a 
name="line.316"></a>
+<span class="sourceLineNo">317</span>  }<a name="line.317"></a>
+<span class="sourceLineNo">318</span><a name="line.318"></a>
+<span class="sourceLineNo">319</span>  @Override<a name="line.319"></a>
+<span class="sourceLineNo">320</span>  public void rethrowExceptionIfFailed() 
throws ForeignException {<a name="line.320"></a>
+<span class="sourceLineNo">321</span>    monitor.rethrowException();<a 
name="line.321"></a>
+<span class="sourceLineNo">322</span>  }<a name="line.322"></a>
+<span class="sourceLineNo">323</span><a name="line.323"></a>
+<span class="sourceLineNo">324</span>  @Override<a name="line.324"></a>
+<span class="sourceLineNo">325</span>  public void rethrowException() throws 
ForeignException {<a name="line.325"></a>
+<span class="sourceLineNo">326</span>    monitor.rethrowException();<a 
name="line.326"></a>
+<span class="sourceLineNo">327</span>  }<a name="line.327"></a>
+<span class="sourceLineNo">328</span><a name="line.328"></a>
+<span class="sourceLineNo">329</span>  @Override<a name="line.329"></a>
+<span class="sourceLineNo">330</span>  public boolean hasException() {<a 
name="line.330"></a>
+<span class="sourceLineNo">331</span>    return monitor.hasException();<a 
name="line.331"></a>
+<span class="sourceLineNo">332</span>  }<a name="line.332"></a>
+<span class="sourceLineNo">333</span><a name="line.333"></a>
+<span class="sourceLineNo">334</span>  @Override<a name="line.334"></a>
+<span class="sourceLineNo">335</span>  public ForeignException getException() 
{<a name="line.335"></a>
+<span class="sourceLineNo">336</span>    return monitor.getException();<a 
name="line.336"></a>
+<span class="sourceLineNo">337</span>  }<a name="line.337"></a>
+<span class="sourceLineNo">338</span><a name="line.338"></a>
+<span class="sourceLineNo">339</span>}<a name="line.339"></a>
 
 
 

Reply via email to