HBASE-16765 New SteppingRegionSplitPolicy, avoid too aggressive spread of regions for small tables.
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/b7293bf5 Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/b7293bf5 Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/b7293bf5 Branch: refs/heads/master Commit: b7293bf5ad7263b2d835c565f59fe1ccb38d23c7 Parents: 1c07d1d Author: Lars Hofhansl <la...@apache.org> Authored: Tue Nov 1 13:12:21 2016 -0700 Committer: Lars Hofhansl <la...@apache.org> Committed: Tue Nov 1 13:12:21 2016 -0700 ---------------------------------------------------------------------- ...IncreasingToUpperBoundRegionSplitPolicy.java | 4 +-- .../hbase/regionserver/SteppingSplitPolicy.java | 32 ++++++++++++++++++++ 2 files changed, 34 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/b7293bf5/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java index 7144cb8..ff68110 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java @@ -45,7 +45,7 @@ import org.apache.hadoop.hbase.classification.InterfaceAudience; public class IncreasingToUpperBoundRegionSplitPolicy extends ConstantSizeRegionSplitPolicy { private static final Log LOG = LogFactory.getLog(IncreasingToUpperBoundRegionSplitPolicy.class); - private long initialSize; + protected long initialSize; @Override protected void configureForRegion(HRegion region) { @@ -116,7 +116,7 @@ public class IncreasingToUpperBoundRegionSplitPolicy extends ConstantSizeRegionS } /** - * @return Region max size or {@code count of regions cubed * flushsize}, + * @return Region max size or {@code count of regions cubed * 2 * flushsize}, * which ever is smaller; guard against there being zero regions on this server. */ protected long getSizeToCheck(final int tableRegionsCount) { http://git-wip-us.apache.org/repos/asf/hbase/blob/b7293bf5/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SteppingSplitPolicy.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SteppingSplitPolicy.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SteppingSplitPolicy.java new file mode 100644 index 0000000..4f3e0f2 --- /dev/null +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SteppingSplitPolicy.java @@ -0,0 +1,32 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.regionserver; + +public class SteppingSplitPolicy extends IncreasingToUpperBoundRegionSplitPolicy { + /** + * @return flushSize * 2 if there's exactly one region of the table in question + * found on this regionserver. Otherwise max file size. + * This allows a table to spread quickly across servers, while avoiding creating + * too many regions. + */ + protected long getSizeToCheck(final int tableRegionsCount) { + return tableRegionsCount == 1 ? this.initialSize : getDesiredMaxFileSize(); + } + + +}
