HBASE-18212 reduce log level for unbuffer warning. In Standalone mode with local filesystem HBase logs Warning message:Failed to invoke 'unbuffer' method in class org.apache.hadoop.fs.FSDataInputStream
Signed-off-by: Umesh Agashe <[email protected]> Signed-off-by: Sean Busbey <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/0f5a250a Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/0f5a250a Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/0f5a250a Branch: refs/heads/branch-2 Commit: 0f5a250ac212d5ded5c3d437565329838cbafcbf Parents: 6012bcd Author: Ashish Singhi <[email protected]> Authored: Fri Jun 16 10:43:56 2017 +0530 Committer: Sean Busbey <[email protected]> Committed: Tue Jun 20 01:11:17 2017 -0500 ---------------------------------------------------------------------- .../hbase/io/FSDataInputStreamWrapper.java | 27 ++++++++++++-------- 1 file changed, 16 insertions(+), 11 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/0f5a250a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java index 25a3373..fb6ebeb 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java @@ -42,6 +42,7 @@ import com.google.common.annotations.VisibleForTesting; @InterfaceAudience.Private public class FSDataInputStreamWrapper implements Closeable { private static final Log LOG = LogFactory.getLog(FSDataInputStreamWrapper.class); + private static final boolean isLogTraceEnabled = LOG.isTraceEnabled(); private final HFileSystem hfs; private final Path path; @@ -274,10 +275,11 @@ public class FSDataInputStreamWrapper implements Closeable { try { this.unbuffer = streamClass.getDeclaredMethod("unbuffer"); } catch (NoSuchMethodException | SecurityException e) { - LOG.warn("Failed to find 'unbuffer' method in class " + streamClass - + " . So there may be a TCP socket connection " - + "left open in CLOSE_WAIT state.", - e); + if (isLogTraceEnabled) { + LOG.trace("Failed to find 'unbuffer' method in class " + streamClass + + " . So there may be a TCP socket connection " + + "left open in CLOSE_WAIT state.", e); + } return; } this.instanceOfCanUnbuffer = true; @@ -289,15 +291,18 @@ public class FSDataInputStreamWrapper implements Closeable { try { this.unbuffer.invoke(wrappedStream); } catch (IllegalAccessException | IllegalArgumentException | InvocationTargetException e) { - LOG.warn("Failed to invoke 'unbuffer' method in class " + streamClass - + " . So there may be a TCP socket connection left open in CLOSE_WAIT state.", - e); + if (isLogTraceEnabled) { + LOG.trace("Failed to invoke 'unbuffer' method in class " + streamClass + + " . So there may be a TCP socket connection left open in CLOSE_WAIT state.", e); + } } } else { - LOG.warn("Failed to find 'unbuffer' method in class " + streamClass - + " . So there may be a TCP socket connection " - + "left open in CLOSE_WAIT state. For more details check " - + "https://issues.apache.org/jira/browse/HBASE-9393";); + if (isLogTraceEnabled) { + LOG.trace("Failed to find 'unbuffer' method in class " + streamClass + + " . So there may be a TCP socket connection " + + "left open in CLOSE_WAIT state. For more details check " + + "https://issues.apache.org/jira/browse/HBASE-9393";); + } } } }
