HBASE-18406 Remove NO-OP Method This patch removes start(MasterProcedureEnv) from ServerCrashProcedure.java which was a misnomer as a no-op. It did not start anything.
Change-Id: I4e91864ace912e137471bfce03516746c4aff83e Signed-off-by: Michael Stack <st...@apache.org> Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/0e9390bd Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/0e9390bd Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/0e9390bd Branch: refs/heads/HBASE-18426 Commit: 0e9390bd6d8a4ad41e48015556786dda9fbdb73b Parents: 5c47cb5 Author: Alex Leblang <alex.lebl...@cloudera.com> Authored: Tue Jul 18 15:01:55 2017 -0700 Committer: Michael Stack <st...@apache.org> Committed: Sun Jul 30 13:59:53 2017 +0100 ---------------------------------------------------------------------- .../hadoop/hbase/master/procedure/ServerCrashProcedure.java | 8 -------- 1 file changed, 8 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/0e9390bd/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java index db4ac32..4fb8c07 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java @@ -139,7 +139,6 @@ implements ServerProcedureInterface { switch (state) { case SERVER_CRASH_START: LOG.info("Start " + this); - start(env); // If carrying meta, process it first. Else, get list of regions on crashed server. if (this.carryingMeta) { setNextState(ServerCrashState.SERVER_CRASH_PROCESS_META); @@ -207,13 +206,6 @@ implements ServerProcedureInterface { } /** - * Start processing of crashed server. In here we'll just set configs. and return. - * @param env - * @throws IOException - */ - private void start(final MasterProcedureEnv env) throws IOException {} - - /** * @param env * @throws IOException * @throws InterruptedException