Repository: hbase-site
Updated Branches:
  refs/heads/asf-site 67479675b -> 05b8d7a55


http://git-wip-us.apache.org/repos/asf/hbase-site/blob/05b8d7a5/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/wal/TestAsyncLogRolling.html
----------------------------------------------------------------------
diff --git 
a/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/wal/TestAsyncLogRolling.html
 
b/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/wal/TestAsyncLogRolling.html
index cca62af..2e3a617 100644
--- 
a/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/wal/TestAsyncLogRolling.html
+++ 
b/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/wal/TestAsyncLogRolling.html
@@ -33,50 +33,51 @@
 <span class="sourceLineNo">025</span>import 
org.apache.hadoop.hbase.CategoryBasedTimeout;<a name="line.25"></a>
 <span class="sourceLineNo">026</span>import 
org.apache.hadoop.hbase.client.RegionInfo;<a name="line.26"></a>
 <span class="sourceLineNo">027</span>import 
org.apache.hadoop.hbase.client.Table;<a name="line.27"></a>
-<span class="sourceLineNo">028</span>import 
org.apache.hadoop.hbase.testclassification.LargeTests;<a name="line.28"></a>
-<span class="sourceLineNo">029</span>import 
org.apache.hadoop.hbase.testclassification.VerySlowRegionServerTests;<a 
name="line.29"></a>
-<span class="sourceLineNo">030</span>import 
org.apache.hadoop.hbase.wal.AsyncFSWALProvider;<a name="line.30"></a>
-<span class="sourceLineNo">031</span>import 
org.apache.hadoop.hbase.wal.WALFactory;<a name="line.31"></a>
-<span class="sourceLineNo">032</span>import 
org.apache.hadoop.hdfs.MiniDFSCluster.DataNodeProperties;<a name="line.32"></a>
-<span class="sourceLineNo">033</span>import 
org.apache.hadoop.hdfs.protocol.DatanodeInfo;<a name="line.33"></a>
-<span class="sourceLineNo">034</span>import org.junit.BeforeClass;<a 
name="line.34"></a>
-<span class="sourceLineNo">035</span>import org.junit.Rule;<a 
name="line.35"></a>
-<span class="sourceLineNo">036</span>import org.junit.Test;<a 
name="line.36"></a>
-<span class="sourceLineNo">037</span>import 
org.junit.experimental.categories.Category;<a name="line.37"></a>
-<span class="sourceLineNo">038</span>import org.junit.rules.TestRule;<a 
name="line.38"></a>
-<span class="sourceLineNo">039</span><a name="line.39"></a>
-<span class="sourceLineNo">040</span>@Category({ 
VerySlowRegionServerTests.class, LargeTests.class })<a name="line.40"></a>
-<span class="sourceLineNo">041</span>public class TestAsyncLogRolling extends 
AbstractTestLogRolling {<a name="line.41"></a>
-<span class="sourceLineNo">042</span>  @Rule public final TestRule timeout = 
CategoryBasedTimeout.builder().withTimeout(this.getClass()).<a 
name="line.42"></a>
-<span class="sourceLineNo">043</span>      
withLookingForStuckThread(true).build();<a name="line.43"></a>
-<span class="sourceLineNo">044</span><a name="line.44"></a>
-<span class="sourceLineNo">045</span>  @BeforeClass<a name="line.45"></a>
-<span class="sourceLineNo">046</span>  public static void setUpBeforeClass() 
throws Exception {<a name="line.46"></a>
-<span class="sourceLineNo">047</span>    Configuration conf = 
TestAsyncLogRolling.TEST_UTIL.getConfiguration();<a name="line.47"></a>
-<span class="sourceLineNo">048</span>    
conf.setInt(AsyncFSWAL.ASYNC_WAL_CREATE_MAX_RETRIES, 100);<a name="line.48"></a>
-<span class="sourceLineNo">049</span>    conf.set(WALFactory.WAL_PROVIDER, 
"asyncfs");<a name="line.49"></a>
-<span class="sourceLineNo">050</span>    
conf.set(WALFactory.META_WAL_PROVIDER, "asyncfs");<a name="line.50"></a>
-<span class="sourceLineNo">051</span>    
AbstractTestLogRolling.setUpBeforeClass();<a name="line.51"></a>
-<span class="sourceLineNo">052</span>  }<a name="line.52"></a>
-<span class="sourceLineNo">053</span><a name="line.53"></a>
-<span class="sourceLineNo">054</span>  @Test(timeout = 180000)<a 
name="line.54"></a>
-<span class="sourceLineNo">055</span>  public void 
testLogRollOnDatanodeDeath() throws IOException, InterruptedException {<a 
name="line.55"></a>
-<span class="sourceLineNo">056</span>    
dfsCluster.startDataNodes(TEST_UTIL.getConfiguration(), 3, true, null, null);<a 
name="line.56"></a>
-<span class="sourceLineNo">057</span>    tableName = getName();<a 
name="line.57"></a>
-<span class="sourceLineNo">058</span>    Table table = 
createTestTable(tableName);<a name="line.58"></a>
-<span class="sourceLineNo">059</span>    
TEST_UTIL.waitUntilAllRegionsAssigned(table.getName());<a name="line.59"></a>
-<span class="sourceLineNo">060</span>    doPut(table, 1);<a name="line.60"></a>
-<span class="sourceLineNo">061</span>    server = 
TEST_UTIL.getRSForFirstRegionInTable(table.getName());<a name="line.61"></a>
-<span class="sourceLineNo">062</span>    RegionInfo hri = 
server.getRegions(table.getName()).get(0).getRegionInfo();<a name="line.62"></a>
-<span class="sourceLineNo">063</span>    AsyncFSWAL wal = (AsyncFSWAL) 
server.getWAL(hri);<a name="line.63"></a>
-<span class="sourceLineNo">064</span>    int numRolledLogFiles = 
AsyncFSWALProvider.getNumRolledLogFiles(wal);<a name="line.64"></a>
-<span class="sourceLineNo">065</span>    DatanodeInfo[] dnInfos = 
wal.getPipeline();<a name="line.65"></a>
-<span class="sourceLineNo">066</span>    DataNodeProperties dnProp = 
TEST_UTIL.getDFSCluster().stopDataNode(dnInfos[0].getName());<a 
name="line.66"></a>
-<span class="sourceLineNo">067</span>    
TEST_UTIL.getDFSCluster().restartDataNode(dnProp);<a name="line.67"></a>
-<span class="sourceLineNo">068</span>    doPut(table, 2);<a name="line.68"></a>
-<span class="sourceLineNo">069</span>    assertEquals(numRolledLogFiles + 1, 
AsyncFSWALProvider.getNumRolledLogFiles(wal));<a name="line.69"></a>
-<span class="sourceLineNo">070</span>  }<a name="line.70"></a>
-<span class="sourceLineNo">071</span>}<a name="line.71"></a>
+<span class="sourceLineNo">028</span>import 
org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper;<a 
name="line.28"></a>
+<span class="sourceLineNo">029</span>import 
org.apache.hadoop.hbase.testclassification.LargeTests;<a name="line.29"></a>
+<span class="sourceLineNo">030</span>import 
org.apache.hadoop.hbase.testclassification.VerySlowRegionServerTests;<a 
name="line.30"></a>
+<span class="sourceLineNo">031</span>import 
org.apache.hadoop.hbase.wal.AsyncFSWALProvider;<a name="line.31"></a>
+<span class="sourceLineNo">032</span>import 
org.apache.hadoop.hbase.wal.WALFactory;<a name="line.32"></a>
+<span class="sourceLineNo">033</span>import 
org.apache.hadoop.hdfs.MiniDFSCluster.DataNodeProperties;<a name="line.33"></a>
+<span class="sourceLineNo">034</span>import 
org.apache.hadoop.hdfs.protocol.DatanodeInfo;<a name="line.34"></a>
+<span class="sourceLineNo">035</span>import org.junit.BeforeClass;<a 
name="line.35"></a>
+<span class="sourceLineNo">036</span>import org.junit.Rule;<a 
name="line.36"></a>
+<span class="sourceLineNo">037</span>import org.junit.Test;<a 
name="line.37"></a>
+<span class="sourceLineNo">038</span>import 
org.junit.experimental.categories.Category;<a name="line.38"></a>
+<span class="sourceLineNo">039</span>import org.junit.rules.TestRule;<a 
name="line.39"></a>
+<span class="sourceLineNo">040</span><a name="line.40"></a>
+<span class="sourceLineNo">041</span>@Category({ 
VerySlowRegionServerTests.class, LargeTests.class })<a name="line.41"></a>
+<span class="sourceLineNo">042</span>public class TestAsyncLogRolling extends 
AbstractTestLogRolling {<a name="line.42"></a>
+<span class="sourceLineNo">043</span>  @Rule public final TestRule timeout = 
CategoryBasedTimeout.builder().withTimeout(this.getClass()).<a 
name="line.43"></a>
+<span class="sourceLineNo">044</span>      
withLookingForStuckThread(true).build();<a name="line.44"></a>
+<span class="sourceLineNo">045</span><a name="line.45"></a>
+<span class="sourceLineNo">046</span>  @BeforeClass<a name="line.46"></a>
+<span class="sourceLineNo">047</span>  public static void setUpBeforeClass() 
throws Exception {<a name="line.47"></a>
+<span class="sourceLineNo">048</span>    Configuration conf = 
TestAsyncLogRolling.TEST_UTIL.getConfiguration();<a name="line.48"></a>
+<span class="sourceLineNo">049</span>    
conf.setInt(FanOutOneBlockAsyncDFSOutputHelper.ASYNC_DFS_OUTPUT_CREATE_MAX_RETRIES,
 100);<a name="line.49"></a>
+<span class="sourceLineNo">050</span>    conf.set(WALFactory.WAL_PROVIDER, 
"asyncfs");<a name="line.50"></a>
+<span class="sourceLineNo">051</span>    
conf.set(WALFactory.META_WAL_PROVIDER, "asyncfs");<a name="line.51"></a>
+<span class="sourceLineNo">052</span>    
AbstractTestLogRolling.setUpBeforeClass();<a name="line.52"></a>
+<span class="sourceLineNo">053</span>  }<a name="line.53"></a>
+<span class="sourceLineNo">054</span><a name="line.54"></a>
+<span class="sourceLineNo">055</span>  @Test(timeout = 180000)<a 
name="line.55"></a>
+<span class="sourceLineNo">056</span>  public void 
testLogRollOnDatanodeDeath() throws IOException, InterruptedException {<a 
name="line.56"></a>
+<span class="sourceLineNo">057</span>    
dfsCluster.startDataNodes(TEST_UTIL.getConfiguration(), 3, true, null, null);<a 
name="line.57"></a>
+<span class="sourceLineNo">058</span>    tableName = getName();<a 
name="line.58"></a>
+<span class="sourceLineNo">059</span>    Table table = 
createTestTable(tableName);<a name="line.59"></a>
+<span class="sourceLineNo">060</span>    
TEST_UTIL.waitUntilAllRegionsAssigned(table.getName());<a name="line.60"></a>
+<span class="sourceLineNo">061</span>    doPut(table, 1);<a name="line.61"></a>
+<span class="sourceLineNo">062</span>    server = 
TEST_UTIL.getRSForFirstRegionInTable(table.getName());<a name="line.62"></a>
+<span class="sourceLineNo">063</span>    RegionInfo hri = 
server.getRegions(table.getName()).get(0).getRegionInfo();<a name="line.63"></a>
+<span class="sourceLineNo">064</span>    AsyncFSWAL wal = (AsyncFSWAL) 
server.getWAL(hri);<a name="line.64"></a>
+<span class="sourceLineNo">065</span>    int numRolledLogFiles = 
AsyncFSWALProvider.getNumRolledLogFiles(wal);<a name="line.65"></a>
+<span class="sourceLineNo">066</span>    DatanodeInfo[] dnInfos = 
wal.getPipeline();<a name="line.66"></a>
+<span class="sourceLineNo">067</span>    DataNodeProperties dnProp = 
TEST_UTIL.getDFSCluster().stopDataNode(dnInfos[0].getName());<a 
name="line.67"></a>
+<span class="sourceLineNo">068</span>    
TEST_UTIL.getDFSCluster().restartDataNode(dnProp);<a name="line.68"></a>
+<span class="sourceLineNo">069</span>    doPut(table, 2);<a name="line.69"></a>
+<span class="sourceLineNo">070</span>    assertEquals(numRolledLogFiles + 1, 
AsyncFSWALProvider.getNumRolledLogFiles(wal));<a name="line.70"></a>
+<span class="sourceLineNo">071</span>  }<a name="line.71"></a>
+<span class="sourceLineNo">072</span>}<a name="line.72"></a>
 
 
 

http://git-wip-us.apache.org/repos/asf/hbase-site/blob/05b8d7a5/testdevapidocs/src-html/org/apache/hadoop/hbase/zookeeper/TestReadOnlyZKClient.html
----------------------------------------------------------------------
diff --git 
a/testdevapidocs/src-html/org/apache/hadoop/hbase/zookeeper/TestReadOnlyZKClient.html
 
b/testdevapidocs/src-html/org/apache/hadoop/hbase/zookeeper/TestReadOnlyZKClient.html
index 781b9f4..b74ca6c 100644
--- 
a/testdevapidocs/src-html/org/apache/hadoop/hbase/zookeeper/TestReadOnlyZKClient.html
+++ 
b/testdevapidocs/src-html/org/apache/hadoop/hbase/zookeeper/TestReadOnlyZKClient.html
@@ -6,7 +6,7 @@
 </head>
 <body>
 <div class="sourceContainer">
-<pre><span class="sourceLineNo">001</span>/*<a name="line.1"></a>
+<pre><span class="sourceLineNo">001</span>/**<a name="line.1"></a>
 <span class="sourceLineNo">002</span> * Licensed to the Apache Software 
Foundation (ASF) under one<a name="line.2"></a>
 <span class="sourceLineNo">003</span> * or more contributor license 
agreements.  See the NOTICE file<a name="line.3"></a>
 <span class="sourceLineNo">004</span> * distributed with this work for 
additional information<a name="line.4"></a>
@@ -35,123 +35,160 @@
 <span class="sourceLineNo">027</span>import static 
org.junit.Assert.assertSame;<a name="line.27"></a>
 <span class="sourceLineNo">028</span>import static 
org.junit.Assert.assertThat;<a name="line.28"></a>
 <span class="sourceLineNo">029</span>import static org.junit.Assert.fail;<a 
name="line.29"></a>
-<span class="sourceLineNo">030</span><a name="line.30"></a>
-<span class="sourceLineNo">031</span>import java.io.IOException;<a 
name="line.31"></a>
-<span class="sourceLineNo">032</span>import 
java.util.concurrent.ExecutionException;<a name="line.32"></a>
-<span class="sourceLineNo">033</span>import 
java.util.concurrent.ThreadLocalRandom;<a name="line.33"></a>
-<span class="sourceLineNo">034</span><a name="line.34"></a>
-<span class="sourceLineNo">035</span>import 
org.apache.hadoop.conf.Configuration;<a name="line.35"></a>
-<span class="sourceLineNo">036</span>import 
org.apache.hadoop.hbase.HBaseZKTestingUtility;<a name="line.36"></a>
-<span class="sourceLineNo">037</span>import 
org.apache.hadoop.hbase.HConstants;<a name="line.37"></a>
-<span class="sourceLineNo">038</span>import 
org.apache.hadoop.hbase.Waiter.ExplainingPredicate;<a name="line.38"></a>
-<span class="sourceLineNo">039</span>import 
org.apache.hadoop.hbase.testclassification.MediumTests;<a name="line.39"></a>
-<span class="sourceLineNo">040</span>import 
org.apache.hadoop.hbase.testclassification.ZKTests;<a name="line.40"></a>
-<span class="sourceLineNo">041</span>import org.apache.zookeeper.CreateMode;<a 
name="line.41"></a>
-<span class="sourceLineNo">042</span>import 
org.apache.zookeeper.KeeperException;<a name="line.42"></a>
-<span class="sourceLineNo">043</span>import 
org.apache.zookeeper.KeeperException.Code;<a name="line.43"></a>
-<span class="sourceLineNo">044</span>import org.apache.zookeeper.ZooDefs;<a 
name="line.44"></a>
-<span class="sourceLineNo">045</span>import org.apache.zookeeper.ZooKeeper;<a 
name="line.45"></a>
-<span class="sourceLineNo">046</span>import org.junit.AfterClass;<a 
name="line.46"></a>
-<span class="sourceLineNo">047</span>import org.junit.BeforeClass;<a 
name="line.47"></a>
-<span class="sourceLineNo">048</span>import org.junit.Test;<a 
name="line.48"></a>
-<span class="sourceLineNo">049</span>import 
org.junit.experimental.categories.Category;<a name="line.49"></a>
-<span class="sourceLineNo">050</span><a name="line.50"></a>
-<span class="sourceLineNo">051</span>@Category({ ZKTests.class, 
MediumTests.class })<a name="line.51"></a>
-<span class="sourceLineNo">052</span>public class TestReadOnlyZKClient {<a 
name="line.52"></a>
-<span class="sourceLineNo">053</span><a name="line.53"></a>
-<span class="sourceLineNo">054</span>  private static HBaseZKTestingUtility 
UTIL = new HBaseZKTestingUtility();<a name="line.54"></a>
-<span class="sourceLineNo">055</span><a name="line.55"></a>
-<span class="sourceLineNo">056</span>  private static int PORT;<a 
name="line.56"></a>
-<span class="sourceLineNo">057</span><a name="line.57"></a>
-<span class="sourceLineNo">058</span>  private static String PATH = "/test";<a 
name="line.58"></a>
-<span class="sourceLineNo">059</span><a name="line.59"></a>
-<span class="sourceLineNo">060</span>  private static byte[] DATA;<a 
name="line.60"></a>
-<span class="sourceLineNo">061</span><a name="line.61"></a>
-<span class="sourceLineNo">062</span>  private static int CHILDREN = 5;<a 
name="line.62"></a>
+<span class="sourceLineNo">030</span>import static 
org.mockito.ArgumentMatchers.any;<a name="line.30"></a>
+<span class="sourceLineNo">031</span>import static 
org.mockito.ArgumentMatchers.anyBoolean;<a name="line.31"></a>
+<span class="sourceLineNo">032</span>import static 
org.mockito.ArgumentMatchers.anyString;<a name="line.32"></a>
+<span class="sourceLineNo">033</span>import static 
org.mockito.Mockito.doAnswer;<a name="line.33"></a>
+<span class="sourceLineNo">034</span>import static org.mockito.Mockito.spy;<a 
name="line.34"></a>
+<span class="sourceLineNo">035</span><a name="line.35"></a>
+<span class="sourceLineNo">036</span>import java.io.IOException;<a 
name="line.36"></a>
+<span class="sourceLineNo">037</span>import 
java.util.concurrent.CompletableFuture;<a name="line.37"></a>
+<span class="sourceLineNo">038</span>import 
java.util.concurrent.CountDownLatch;<a name="line.38"></a>
+<span class="sourceLineNo">039</span>import 
java.util.concurrent.ExecutionException;<a name="line.39"></a>
+<span class="sourceLineNo">040</span>import 
java.util.concurrent.ThreadLocalRandom;<a name="line.40"></a>
+<span class="sourceLineNo">041</span>import 
org.apache.hadoop.conf.Configuration;<a name="line.41"></a>
+<span class="sourceLineNo">042</span>import 
org.apache.hadoop.hbase.HBaseZKTestingUtility;<a name="line.42"></a>
+<span class="sourceLineNo">043</span>import 
org.apache.hadoop.hbase.HConstants;<a name="line.43"></a>
+<span class="sourceLineNo">044</span>import 
org.apache.hadoop.hbase.Waiter.ExplainingPredicate;<a name="line.44"></a>
+<span class="sourceLineNo">045</span>import 
org.apache.hadoop.hbase.testclassification.MediumTests;<a name="line.45"></a>
+<span class="sourceLineNo">046</span>import 
org.apache.hadoop.hbase.testclassification.ZKTests;<a name="line.46"></a>
+<span class="sourceLineNo">047</span>import 
org.apache.zookeeper.AsyncCallback.StatCallback;<a name="line.47"></a>
+<span class="sourceLineNo">048</span>import org.apache.zookeeper.CreateMode;<a 
name="line.48"></a>
+<span class="sourceLineNo">049</span>import 
org.apache.zookeeper.KeeperException;<a name="line.49"></a>
+<span class="sourceLineNo">050</span>import 
org.apache.zookeeper.KeeperException.Code;<a name="line.50"></a>
+<span class="sourceLineNo">051</span>import org.apache.zookeeper.ZooDefs;<a 
name="line.51"></a>
+<span class="sourceLineNo">052</span>import org.apache.zookeeper.ZooKeeper;<a 
name="line.52"></a>
+<span class="sourceLineNo">053</span>import org.apache.zookeeper.data.Stat;<a 
name="line.53"></a>
+<span class="sourceLineNo">054</span>import org.junit.AfterClass;<a 
name="line.54"></a>
+<span class="sourceLineNo">055</span>import org.junit.BeforeClass;<a 
name="line.55"></a>
+<span class="sourceLineNo">056</span>import org.junit.Test;<a 
name="line.56"></a>
+<span class="sourceLineNo">057</span>import 
org.junit.experimental.categories.Category;<a name="line.57"></a>
+<span class="sourceLineNo">058</span>import 
org.mockito.invocation.InvocationOnMock;<a name="line.58"></a>
+<span class="sourceLineNo">059</span>import org.mockito.stubbing.Answer;<a 
name="line.59"></a>
+<span class="sourceLineNo">060</span><a name="line.60"></a>
+<span class="sourceLineNo">061</span>@Category({ ZKTests.class, 
MediumTests.class })<a name="line.61"></a>
+<span class="sourceLineNo">062</span>public class TestReadOnlyZKClient {<a 
name="line.62"></a>
 <span class="sourceLineNo">063</span><a name="line.63"></a>
-<span class="sourceLineNo">064</span>  private static ReadOnlyZKClient 
RO_ZK;<a name="line.64"></a>
+<span class="sourceLineNo">064</span>  private static HBaseZKTestingUtility 
UTIL = new HBaseZKTestingUtility();<a name="line.64"></a>
 <span class="sourceLineNo">065</span><a name="line.65"></a>
-<span class="sourceLineNo">066</span>  @BeforeClass<a name="line.66"></a>
-<span class="sourceLineNo">067</span>  public static void setUp() throws 
Exception {<a name="line.67"></a>
-<span class="sourceLineNo">068</span>    PORT = 
UTIL.startMiniZKCluster().getClientPort();<a name="line.68"></a>
+<span class="sourceLineNo">066</span>  private static int PORT;<a 
name="line.66"></a>
+<span class="sourceLineNo">067</span><a name="line.67"></a>
+<span class="sourceLineNo">068</span>  private static String PATH = "/test";<a 
name="line.68"></a>
 <span class="sourceLineNo">069</span><a name="line.69"></a>
-<span class="sourceLineNo">070</span>    ZooKeeper zk = ZooKeeperHelper.<a 
name="line.70"></a>
-<span class="sourceLineNo">071</span>        
getConnectedZooKeeper("localhost:" + PORT, 10000);<a name="line.71"></a>
-<span class="sourceLineNo">072</span>    DATA = new byte[10];<a 
name="line.72"></a>
-<span class="sourceLineNo">073</span>    
ThreadLocalRandom.current().nextBytes(DATA);<a name="line.73"></a>
-<span class="sourceLineNo">074</span>    zk.create(PATH, DATA, 
ZooDefs.Ids.OPEN_ACL_UNSAFE, CreateMode.PERSISTENT);<a name="line.74"></a>
-<span class="sourceLineNo">075</span>    for (int i = 0; i &lt; CHILDREN; i++) 
{<a name="line.75"></a>
-<span class="sourceLineNo">076</span>      zk.create(PATH + "/c" + i, new 
byte[0], ZooDefs.Ids.OPEN_ACL_UNSAFE, CreateMode.PERSISTENT);<a 
name="line.76"></a>
-<span class="sourceLineNo">077</span>    }<a name="line.77"></a>
-<span class="sourceLineNo">078</span>    zk.close();<a name="line.78"></a>
-<span class="sourceLineNo">079</span>    Configuration conf = 
UTIL.getConfiguration();<a name="line.79"></a>
-<span class="sourceLineNo">080</span>    conf.set(HConstants.ZOOKEEPER_QUORUM, 
"localhost:" + PORT);<a name="line.80"></a>
-<span class="sourceLineNo">081</span>    
conf.setInt(ReadOnlyZKClient.RECOVERY_RETRY, 3);<a name="line.81"></a>
-<span class="sourceLineNo">082</span>    
conf.setInt(ReadOnlyZKClient.RECOVERY_RETRY_INTERVAL_MILLIS, 100);<a 
name="line.82"></a>
-<span class="sourceLineNo">083</span>    
conf.setInt(ReadOnlyZKClient.KEEPALIVE_MILLIS, 3000);<a name="line.83"></a>
-<span class="sourceLineNo">084</span>    RO_ZK = new ReadOnlyZKClient(conf);<a 
name="line.84"></a>
-<span class="sourceLineNo">085</span>    // only connect when necessary<a 
name="line.85"></a>
-<span class="sourceLineNo">086</span>    assertNull(RO_ZK.getZooKeeper());<a 
name="line.86"></a>
-<span class="sourceLineNo">087</span>  }<a name="line.87"></a>
-<span class="sourceLineNo">088</span><a name="line.88"></a>
-<span class="sourceLineNo">089</span>  @AfterClass<a name="line.89"></a>
-<span class="sourceLineNo">090</span>  public static void tearDown() throws 
IOException {<a name="line.90"></a>
-<span class="sourceLineNo">091</span>    RO_ZK.close();<a name="line.91"></a>
-<span class="sourceLineNo">092</span>    UTIL.shutdownMiniZKCluster();<a 
name="line.92"></a>
-<span class="sourceLineNo">093</span>    UTIL.cleanupTestDir();<a 
name="line.93"></a>
-<span class="sourceLineNo">094</span>  }<a name="line.94"></a>
-<span class="sourceLineNo">095</span><a name="line.95"></a>
-<span class="sourceLineNo">096</span>  @Test<a name="line.96"></a>
-<span class="sourceLineNo">097</span>  public void testGetAndExists() throws 
Exception {<a name="line.97"></a>
-<span class="sourceLineNo">098</span>    assertArrayEquals(DATA, 
RO_ZK.get(PATH).get());<a name="line.98"></a>
-<span class="sourceLineNo">099</span>    assertEquals(CHILDREN, 
RO_ZK.exists(PATH).get().getNumChildren());<a name="line.99"></a>
-<span class="sourceLineNo">100</span>    
assertNotNull(RO_ZK.getZooKeeper());<a name="line.100"></a>
-<span class="sourceLineNo">101</span>    // The zookeeper client should be 
closed finally after the keep alive time elapsed<a name="line.101"></a>
-<span class="sourceLineNo">102</span>    UTIL.waitFor(10000, new 
ExplainingPredicate&lt;Exception&gt;() {<a name="line.102"></a>
-<span class="sourceLineNo">103</span><a name="line.103"></a>
-<span class="sourceLineNo">104</span>      @Override<a name="line.104"></a>
-<span class="sourceLineNo">105</span>      public boolean evaluate() throws 
Exception {<a name="line.105"></a>
-<span class="sourceLineNo">106</span>        return RO_ZK.getZooKeeper() == 
null;<a name="line.106"></a>
-<span class="sourceLineNo">107</span>      }<a name="line.107"></a>
+<span class="sourceLineNo">070</span>  private static byte[] DATA;<a 
name="line.70"></a>
+<span class="sourceLineNo">071</span><a name="line.71"></a>
+<span class="sourceLineNo">072</span>  private static int CHILDREN = 5;<a 
name="line.72"></a>
+<span class="sourceLineNo">073</span><a name="line.73"></a>
+<span class="sourceLineNo">074</span>  private static ReadOnlyZKClient 
RO_ZK;<a name="line.74"></a>
+<span class="sourceLineNo">075</span><a name="line.75"></a>
+<span class="sourceLineNo">076</span>  @BeforeClass<a name="line.76"></a>
+<span class="sourceLineNo">077</span>  public static void setUp() throws 
Exception {<a name="line.77"></a>
+<span class="sourceLineNo">078</span>    PORT = 
UTIL.startMiniZKCluster().getClientPort();<a name="line.78"></a>
+<span class="sourceLineNo">079</span><a name="line.79"></a>
+<span class="sourceLineNo">080</span>    ZooKeeper zk = 
ZooKeeperHelper.getConnectedZooKeeper("localhost:" + PORT, 10000);<a 
name="line.80"></a>
+<span class="sourceLineNo">081</span>    DATA = new byte[10];<a 
name="line.81"></a>
+<span class="sourceLineNo">082</span>    
ThreadLocalRandom.current().nextBytes(DATA);<a name="line.82"></a>
+<span class="sourceLineNo">083</span>    zk.create(PATH, DATA, 
ZooDefs.Ids.OPEN_ACL_UNSAFE, CreateMode.PERSISTENT);<a name="line.83"></a>
+<span class="sourceLineNo">084</span>    for (int i = 0; i &lt; CHILDREN; i++) 
{<a name="line.84"></a>
+<span class="sourceLineNo">085</span>      zk.create(PATH + "/c" + i, new 
byte[0], ZooDefs.Ids.OPEN_ACL_UNSAFE, CreateMode.PERSISTENT);<a 
name="line.85"></a>
+<span class="sourceLineNo">086</span>    }<a name="line.86"></a>
+<span class="sourceLineNo">087</span>    zk.close();<a name="line.87"></a>
+<span class="sourceLineNo">088</span>    Configuration conf = 
UTIL.getConfiguration();<a name="line.88"></a>
+<span class="sourceLineNo">089</span>    conf.set(HConstants.ZOOKEEPER_QUORUM, 
"localhost:" + PORT);<a name="line.89"></a>
+<span class="sourceLineNo">090</span>    
conf.setInt(ReadOnlyZKClient.RECOVERY_RETRY, 3);<a name="line.90"></a>
+<span class="sourceLineNo">091</span>    
conf.setInt(ReadOnlyZKClient.RECOVERY_RETRY_INTERVAL_MILLIS, 100);<a 
name="line.91"></a>
+<span class="sourceLineNo">092</span>    
conf.setInt(ReadOnlyZKClient.KEEPALIVE_MILLIS, 3000);<a name="line.92"></a>
+<span class="sourceLineNo">093</span>    RO_ZK = new ReadOnlyZKClient(conf);<a 
name="line.93"></a>
+<span class="sourceLineNo">094</span>    // only connect when necessary<a 
name="line.94"></a>
+<span class="sourceLineNo">095</span>    assertNull(RO_ZK.zookeeper);<a 
name="line.95"></a>
+<span class="sourceLineNo">096</span>  }<a name="line.96"></a>
+<span class="sourceLineNo">097</span><a name="line.97"></a>
+<span class="sourceLineNo">098</span>  @AfterClass<a name="line.98"></a>
+<span class="sourceLineNo">099</span>  public static void tearDown() throws 
IOException {<a name="line.99"></a>
+<span class="sourceLineNo">100</span>    RO_ZK.close();<a name="line.100"></a>
+<span class="sourceLineNo">101</span>    UTIL.shutdownMiniZKCluster();<a 
name="line.101"></a>
+<span class="sourceLineNo">102</span>    UTIL.cleanupTestDir();<a 
name="line.102"></a>
+<span class="sourceLineNo">103</span>  }<a name="line.103"></a>
+<span class="sourceLineNo">104</span><a name="line.104"></a>
+<span class="sourceLineNo">105</span>  private void 
waitForIdleConnectionClosed() throws Exception {<a name="line.105"></a>
+<span class="sourceLineNo">106</span>    // The zookeeper client should be 
closed finally after the keep alive time elapsed<a name="line.106"></a>
+<span class="sourceLineNo">107</span>    UTIL.waitFor(10000, new 
ExplainingPredicate&lt;Exception&gt;() {<a name="line.107"></a>
 <span class="sourceLineNo">108</span><a name="line.108"></a>
 <span class="sourceLineNo">109</span>      @Override<a name="line.109"></a>
-<span class="sourceLineNo">110</span>      public String explainFailure() 
throws Exception {<a name="line.110"></a>
-<span class="sourceLineNo">111</span>        return "Connection to zookeeper 
is still alive";<a name="line.111"></a>
+<span class="sourceLineNo">110</span>      public boolean evaluate() throws 
Exception {<a name="line.110"></a>
+<span class="sourceLineNo">111</span>        return RO_ZK.zookeeper == null;<a 
name="line.111"></a>
 <span class="sourceLineNo">112</span>      }<a name="line.112"></a>
-<span class="sourceLineNo">113</span>    });<a name="line.113"></a>
-<span class="sourceLineNo">114</span>  }<a name="line.114"></a>
-<span class="sourceLineNo">115</span><a name="line.115"></a>
-<span class="sourceLineNo">116</span>  @Test<a name="line.116"></a>
-<span class="sourceLineNo">117</span>  public void testNoNode() throws 
InterruptedException, ExecutionException {<a name="line.117"></a>
-<span class="sourceLineNo">118</span>    String pathNotExists = PATH + 
"_whatever";<a name="line.118"></a>
-<span class="sourceLineNo">119</span>    try {<a name="line.119"></a>
-<span class="sourceLineNo">120</span>      RO_ZK.get(pathNotExists).get();<a 
name="line.120"></a>
-<span class="sourceLineNo">121</span>      fail("should fail because of " + 
pathNotExists + " does not exist");<a name="line.121"></a>
-<span class="sourceLineNo">122</span>    } catch (ExecutionException e) {<a 
name="line.122"></a>
-<span class="sourceLineNo">123</span>      assertThat(e.getCause(), 
instanceOf(KeeperException.class));<a name="line.123"></a>
-<span class="sourceLineNo">124</span>      KeeperException ke = 
(KeeperException) e.getCause();<a name="line.124"></a>
-<span class="sourceLineNo">125</span>      assertEquals(Code.NONODE, 
ke.code());<a name="line.125"></a>
-<span class="sourceLineNo">126</span>      assertEquals(pathNotExists, 
ke.getPath());<a name="line.126"></a>
-<span class="sourceLineNo">127</span>    }<a name="line.127"></a>
-<span class="sourceLineNo">128</span>    // exists will not throw exception.<a 
name="line.128"></a>
-<span class="sourceLineNo">129</span>    
assertNull(RO_ZK.exists(pathNotExists).get());<a name="line.129"></a>
-<span class="sourceLineNo">130</span>  }<a name="line.130"></a>
-<span class="sourceLineNo">131</span><a name="line.131"></a>
-<span class="sourceLineNo">132</span>  @Test<a name="line.132"></a>
-<span class="sourceLineNo">133</span>  public void testSessionExpire() throws 
Exception {<a name="line.133"></a>
-<span class="sourceLineNo">134</span>    assertArrayEquals(DATA, 
RO_ZK.get(PATH).get());<a name="line.134"></a>
-<span class="sourceLineNo">135</span>    ZooKeeper zk = 
RO_ZK.getZooKeeper();<a name="line.135"></a>
-<span class="sourceLineNo">136</span>    long sessionId = zk.getSessionId();<a 
name="line.136"></a>
-<span class="sourceLineNo">137</span>    
UTIL.getZkCluster().getZooKeeperServers().get(0).closeSession(sessionId);<a 
name="line.137"></a>
-<span class="sourceLineNo">138</span>    // should not reach keep alive so 
still the same instance<a name="line.138"></a>
-<span class="sourceLineNo">139</span>    assertSame(zk, 
RO_ZK.getZooKeeper());<a name="line.139"></a>
-<span class="sourceLineNo">140</span>    byte [] got = 
RO_ZK.get(PATH).get();<a name="line.140"></a>
-<span class="sourceLineNo">141</span>    assertArrayEquals(DATA, got);<a 
name="line.141"></a>
-<span class="sourceLineNo">142</span>    
assertNotNull(RO_ZK.getZooKeeper());<a name="line.142"></a>
-<span class="sourceLineNo">143</span>    assertNotSame(zk, 
RO_ZK.getZooKeeper());<a name="line.143"></a>
-<span class="sourceLineNo">144</span>    assertNotEquals(sessionId, 
RO_ZK.getZooKeeper().getSessionId());<a name="line.144"></a>
-<span class="sourceLineNo">145</span>  }<a name="line.145"></a>
-<span class="sourceLineNo">146</span>}<a name="line.146"></a>
+<span class="sourceLineNo">113</span><a name="line.113"></a>
+<span class="sourceLineNo">114</span>      @Override<a name="line.114"></a>
+<span class="sourceLineNo">115</span>      public String explainFailure() 
throws Exception {<a name="line.115"></a>
+<span class="sourceLineNo">116</span>        return "Connection to zookeeper 
is still alive";<a name="line.116"></a>
+<span class="sourceLineNo">117</span>      }<a name="line.117"></a>
+<span class="sourceLineNo">118</span>    });<a name="line.118"></a>
+<span class="sourceLineNo">119</span>  }<a name="line.119"></a>
+<span class="sourceLineNo">120</span><a name="line.120"></a>
+<span class="sourceLineNo">121</span>  @Test<a name="line.121"></a>
+<span class="sourceLineNo">122</span>  public void testGetAndExists() throws 
Exception {<a name="line.122"></a>
+<span class="sourceLineNo">123</span>    assertArrayEquals(DATA, 
RO_ZK.get(PATH).get());<a name="line.123"></a>
+<span class="sourceLineNo">124</span>    assertEquals(CHILDREN, 
RO_ZK.exists(PATH).get().getNumChildren());<a name="line.124"></a>
+<span class="sourceLineNo">125</span>    assertNotNull(RO_ZK.zookeeper);<a 
name="line.125"></a>
+<span class="sourceLineNo">126</span>    waitForIdleConnectionClosed();<a 
name="line.126"></a>
+<span class="sourceLineNo">127</span>  }<a name="line.127"></a>
+<span class="sourceLineNo">128</span><a name="line.128"></a>
+<span class="sourceLineNo">129</span>  @Test<a name="line.129"></a>
+<span class="sourceLineNo">130</span>  public void testNoNode() throws 
InterruptedException, ExecutionException {<a name="line.130"></a>
+<span class="sourceLineNo">131</span>    String pathNotExists = PATH + 
"_whatever";<a name="line.131"></a>
+<span class="sourceLineNo">132</span>    try {<a name="line.132"></a>
+<span class="sourceLineNo">133</span>      RO_ZK.get(pathNotExists).get();<a 
name="line.133"></a>
+<span class="sourceLineNo">134</span>      fail("should fail because of " + 
pathNotExists + " does not exist");<a name="line.134"></a>
+<span class="sourceLineNo">135</span>    } catch (ExecutionException e) {<a 
name="line.135"></a>
+<span class="sourceLineNo">136</span>      assertThat(e.getCause(), 
instanceOf(KeeperException.class));<a name="line.136"></a>
+<span class="sourceLineNo">137</span>      KeeperException ke = 
(KeeperException) e.getCause();<a name="line.137"></a>
+<span class="sourceLineNo">138</span>      assertEquals(Code.NONODE, 
ke.code());<a name="line.138"></a>
+<span class="sourceLineNo">139</span>      assertEquals(pathNotExists, 
ke.getPath());<a name="line.139"></a>
+<span class="sourceLineNo">140</span>    }<a name="line.140"></a>
+<span class="sourceLineNo">141</span>    // exists will not throw exception.<a 
name="line.141"></a>
+<span class="sourceLineNo">142</span>    
assertNull(RO_ZK.exists(pathNotExists).get());<a name="line.142"></a>
+<span class="sourceLineNo">143</span>  }<a name="line.143"></a>
+<span class="sourceLineNo">144</span><a name="line.144"></a>
+<span class="sourceLineNo">145</span>  @Test<a name="line.145"></a>
+<span class="sourceLineNo">146</span>  public void testSessionExpire() throws 
Exception {<a name="line.146"></a>
+<span class="sourceLineNo">147</span>    assertArrayEquals(DATA, 
RO_ZK.get(PATH).get());<a name="line.147"></a>
+<span class="sourceLineNo">148</span>    ZooKeeper zk = RO_ZK.zookeeper;<a 
name="line.148"></a>
+<span class="sourceLineNo">149</span>    long sessionId = zk.getSessionId();<a 
name="line.149"></a>
+<span class="sourceLineNo">150</span>    
UTIL.getZkCluster().getZooKeeperServers().get(0).closeSession(sessionId);<a 
name="line.150"></a>
+<span class="sourceLineNo">151</span>    // should not reach keep alive so 
still the same instance<a name="line.151"></a>
+<span class="sourceLineNo">152</span>    assertSame(zk, RO_ZK.zookeeper);<a 
name="line.152"></a>
+<span class="sourceLineNo">153</span>    byte[] got = RO_ZK.get(PATH).get();<a 
name="line.153"></a>
+<span class="sourceLineNo">154</span>    assertArrayEquals(DATA, got);<a 
name="line.154"></a>
+<span class="sourceLineNo">155</span>    assertNotNull(RO_ZK.zookeeper);<a 
name="line.155"></a>
+<span class="sourceLineNo">156</span>    assertNotSame(zk, RO_ZK.zookeeper);<a 
name="line.156"></a>
+<span class="sourceLineNo">157</span>    assertNotEquals(sessionId, 
RO_ZK.zookeeper.getSessionId());<a name="line.157"></a>
+<span class="sourceLineNo">158</span>  }<a name="line.158"></a>
+<span class="sourceLineNo">159</span><a name="line.159"></a>
+<span class="sourceLineNo">160</span>  @Test<a name="line.160"></a>
+<span class="sourceLineNo">161</span>  public void testNotCloseZkWhenPending() 
throws Exception {<a name="line.161"></a>
+<span class="sourceLineNo">162</span>    assertArrayEquals(DATA, 
RO_ZK.get(PATH).get());<a name="line.162"></a>
+<span class="sourceLineNo">163</span>    ZooKeeper mockedZK = 
spy(RO_ZK.zookeeper);<a name="line.163"></a>
+<span class="sourceLineNo">164</span>    CountDownLatch latch = new 
CountDownLatch(1);<a name="line.164"></a>
+<span class="sourceLineNo">165</span>    doAnswer(new Answer&lt;Object&gt;() 
{<a name="line.165"></a>
+<span class="sourceLineNo">166</span><a name="line.166"></a>
+<span class="sourceLineNo">167</span>      @Override<a name="line.167"></a>
+<span class="sourceLineNo">168</span>      public Object 
answer(InvocationOnMock invocation) throws Throwable {<a name="line.168"></a>
+<span class="sourceLineNo">169</span>        latch.await();<a 
name="line.169"></a>
+<span class="sourceLineNo">170</span>        return 
invocation.callRealMethod();<a name="line.170"></a>
+<span class="sourceLineNo">171</span>      }<a name="line.171"></a>
+<span class="sourceLineNo">172</span>    }).when(mockedZK).exists(anyString(), 
anyBoolean(), any(StatCallback.class), any());<a name="line.172"></a>
+<span class="sourceLineNo">173</span>    RO_ZK.zookeeper = mockedZK;<a 
name="line.173"></a>
+<span class="sourceLineNo">174</span>    CompletableFuture&lt;Stat&gt; future 
= RO_ZK.exists(PATH);<a name="line.174"></a>
+<span class="sourceLineNo">175</span>    // 2 * keep alive time to ensure that 
we will not close the zk when there are pending requests<a name="line.175"></a>
+<span class="sourceLineNo">176</span>    Thread.sleep(6000);<a 
name="line.176"></a>
+<span class="sourceLineNo">177</span>    assertNotNull(RO_ZK.zookeeper);<a 
name="line.177"></a>
+<span class="sourceLineNo">178</span>    latch.countDown();<a 
name="line.178"></a>
+<span class="sourceLineNo">179</span>    assertEquals(CHILDREN, 
future.get().getNumChildren());<a name="line.179"></a>
+<span class="sourceLineNo">180</span>    // now we will close the idle 
connection.<a name="line.180"></a>
+<span class="sourceLineNo">181</span>    waitForIdleConnectionClosed();<a 
name="line.181"></a>
+<span class="sourceLineNo">182</span>  }<a name="line.182"></a>
+<span class="sourceLineNo">183</span>}<a name="line.183"></a>
 
 
 

Reply via email to